Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if the properties exist #92

Merged
merged 2 commits into from Nov 15, 2022
Merged

Check if the properties exist #92

merged 2 commits into from Nov 15, 2022

Conversation

jazzsequence
Copy link
Contributor

Before using the class property values to determine the output, we need to check if they've been set.

Overview

This pull request:

Q A
Bug fix? yes
New feature? no
Has tests? no
BC breaks? no
Deprecations? no

@jazzsequence
Check if the properties exist
8fc6829 
Before using the class property values to determine the output, we need to check if they've been set.
@jazzsequence
Remove spacing
c89f88f
@jazzsequence jazzsequence marked this pull request as ready for review November 15, 2022 21:05
@jazzsequence jazzsequence requested a review from a team as a code owner November 15, 2022 21:05
@jazzsequence jazzsequence self-assigned this Nov 15, 2022
jspellman814
jspellman814 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@jspellman814 jspellman814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jazzsequence jazzsequence merged commit 889ae6c into master Nov 15, 2022
@jazzsequence jazzsequence deleted the check-if-property-exists branch November 15, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspellman814 jspellman814 jspellman814 approved these changes

Assignees

@jazzsequence jazzsequence

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jazzsequence @jspellman814