Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB-5837: Improve Handling of Secrets Field #53

Merged
merged 1 commit into from Aug 7, 2023
Merged

DB-5837: Improve Handling of Secrets Field #53

merged 1 commit into from Aug 7, 2023

Conversation

backlineint
Copy link
Contributor

Refactor shared secret field to retain value as placeholder

@backlineint backlineint requested review from a team as code owners August 7, 2023 16:33
@backlineint backlineint changed the base branch from main to develop August 7, 2023 19:47
mitchellmarkoff
mitchellmarkoff approved these changes Aug 7, 2023
View reviewed changes
Copy link

@mitchellmarkoff mitchellmarkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, still working as expected locally 🏄‍♂️

@mitchellmarkoff mitchellmarkoff merged commit 6c47bd6 into pantheon-systems:develop Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchellmarkoff mitchellmarkoff mitchellmarkoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@backlineint @mitchellmarkoff