fix: Fixes incorrect order of array_replace_recursive arguments & other issues #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
timnolte
commented
Jun 21, 2023
•
timnolte
commented
- Fixes Changes Merged from #360 Break Redis Connections on Pantheon Due to #400 and Incorrect array_replace_recursive call #433
- Fixes [CMSP-470] Replace use of wp_strip_all_tags (possibly any wp filter function?) in object-cache.php #432
- Fixes [CMSP-467] Please don't strip all tags from the cache password. #431
- Further clean-up & standardization between object-cache.php & wp-redis.php.
- Fixes incorrect order of array_replace_recursive arguments.
- Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use.
timnolte
force-pushed
the
fix/433-array_replace_recursive
branch
from
e123ced
to
26e9d03
Compare
|
Ah, looks like PHPCS is unhappy, though really it is incorrectly unhappy. I'll try to resolve those linting issues. |
jazzsequence
requested changes
Jun 23, 2023
pwtyler
reviewed
Jun 23, 2023
…er issues * Fixes pantheon-systems#433 * Fixes pantheon-systems#432 * Fixes pantheon-systems#431 * Further clean-up & standardization between object-cache.php & wp-redis.php. * Fixes incorrect order of array_replace_recursive arguments. * Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use.
* Adjusts some items to use type-based sanitization. * Adds linting expection handling with comments for cases that require it.
* Reverts this incorrect change that was made due to the incorrect use of `array_replace_recursive()`.
jazzsequence
force-pushed
the
fix/433-array_replace_recursive
branch
from
37d25d1
to
3de4ad3
Compare
jazzsequence
approved these changes
Jun 23, 2023
|
Thanks for your patience @timnolte. We'll get a release ready for a Monday deploy. |
Merged
jazzsequence
added a commit
that referenced
this pull request
Jun 26, 2023
…er issues (#434) * fix: Fixes incorrect order of array_replace_recursive arguments & other issues * Fixes #433 * Fixes #432 * Fixes #431 * Further clean-up & standardization between object-cache.php & wp-redis.php. * Fixes incorrect order of array_replace_recursive arguments. * Addresses issue with port still not being null for socket connections due to defaults array_repalce_recursive use. * fix: Fixes sanitization methods and linting issues * Adjusts some items to use type-based sanitization. * Adds linting expection handling with comments for cases that require it. * fix: Removes invalid change made in #437 * Reverts this incorrect change that was made due to the incorrect use of `array_replace_recursive()`. * update changelog * Update wp-redis.php * update language in changelogs * fix missing closing ) --------- Co-authored-by: Chris Reynolds <chris@jazzsequence.com> Co-authored-by: Phil Tyler <philip@tylerdigital.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.