Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update snowflake queries with p_occurs_since #1265

Merged
merged 4 commits into from
Jun 18, 2024
Merged

update snowflake queries with p_occurs_since #1265

merged 4 commits into from
Jun 18, 2024

Conversation

arielkr256
Copy link
Contributor

Background

DATEDIFF(HOUR, event_timestamp, CURRENT_TIMESTAMP) < 24 was observed to have performance issues

Changes

  • alias timestamp fields as p_event_time
  • refactor to use p_occurs_since macro instead of DATEDIFF

Testing

  • manually ran all queries in a test environment

@arielkr256 arielkr256 requested a review from a team as a code owner June 17, 2024 15:46
@github-actions GitHub Actions
Copy link

😱
looks like some things could be wrong with the packs

[INFO][root]: ignoring file dependabot.yml

@arielkr256 arielkr256 merged commit 33335ca into release Jun 18, 2024
6 checks passed
@arielkr256 arielkr256 deleted the threat-344-snowflake-query-performance branch June 18, 2024 15:16
ben-githubs pushed a commit that referenced this pull request Jun 27, 2024
@arielkr256 @ben-githubs
update snowflake queries with p_occurs_since (#1265)
2e97668 
* update snowflake queries with p_occurs_since

* a few more fixes

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le4ker le4ker le4ker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@arielkr256 @le4ker