Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added removed workspace.settings line back #902

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

tiffany-leong
Copy link
Contributor

A minor bug which results in the state variable always being set to "<NO_STATE_FOUND>" so the title doesn't display correctly.

Background

"workspace.settings.enforce_saml_sso_config_updated" line required to determine if state is enabled

Changes

  • Added the line "workspace.settings.enforce_saml_sso_config_updated", back.

Testing

Added the line "workspace.settings.enforce_saml_sso_config_updated", back. Confirmed with Ariel that it's a minor bug which results in the state variable always being set to "<NO_STATE_FOUND>" so the title doesn't display correctly.
@tiffany-leong tiffany-leong requested a review from a team October 19, 2023 18:24
Copy link
Contributor

@arielkr256 arielkr256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@arielkr256 arielkr256 merged commit 0b6e7f9 into master Oct 20, 2023
4 checks passed
@arielkr256 arielkr256 deleted the tiffany-notion-detection-patch branch October 20, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants