Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools are not built to match Pants minimum supported platforms #78

Open
jsirois opened this issue Jul 23, 2018 · 2 comments
Open

Tools are not built to match Pants minimum supported platforms #78

jsirois opened this issue Jul 23, 2018 · 2 comments

Comments

@jsirois
Copy link
Contributor

jsirois commented Jul 23, 2018

For example, Pants builds OSX wheels against OSX 10.11 (see https://github.com/pantsbuild/pants/blob/master/.travis.yml#L92 and https://docs.travis-ci.com/user/reference/osx/#OS-X-Version), but we see:

screenshot_20180722-220434

We should probably use a CI job to build any binaries not on S3 using the same minimum images we use in pantsbuild/pants.

@jsirois
Copy link
Contributor Author

jsirois commented Jul 23, 2018

/cc @cosmicexplorer

This is a long standing problem with the way we build binaries and you just got unlucky. I'm going to tackle this tomorrow but likely lean on you for review.

@jsirois jsirois self-assigned this Jul 23, 2018
@jsirois
Copy link
Contributor Author

jsirois commented Jul 23, 2018

The list of problem binaries based on our current floor of OSX 10.11:

$ find build-support/ -type f ! -type l | grep -E "/mac/10.1[2-9]/" | xargs file | grep executable | grep -v "ASCII text executable"
build-support/bin/ragel/mac/10.12/6.9/ragel:                                                        Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE>
build-support/bin/fs_util/mac/10.13/1.4.0.dev23/fs_util:                                            Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE|HAS_TLV_DESCRIPTORS>
build-support/bin/buildozer/mac/10.13/0.6.0-80c7f0d45d7e40fa1f7362852697d4a03df557b3/buildozer:     Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS>
build-support/bin/buildozer/mac/10.13/0.6.0-1a9c38e0df9397d033a1ca535596de5a7c1cf18f/buildozer:     Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS>
build-support/bin/buildifier/mac/10.13/0.6.0-1a9c38e0df9397d033a1ca535596de5a7c1cf18f/buildifier:   Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS>
build-support/bin/thrift/mac/10.12/0.7.0/thrift:                                                    Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE>
build-support/bin/thrift/mac/10.12/0.5.0-finagle/thrift:                                            Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE>
build-support/bin/thrift/mac/10.12/0.9.2/thrift:                                                    Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE>
build-support/bin/thrift/mac/10.12/0.9.1/thrift:                                                    Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE>
build-support/bin/thrift/mac/10.12/0.9.3/thrift:                                                    Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE>
build-support/bin/watchman/mac/10.13/4.9.0-pants1/watchman:                                         Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE>
build-support/bin/watchman/mac/10.12/4.5.0/watchman:                                                Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|PIE>
build-support/bin/watchman/mac/10.12/4.9.0/watchman:                                                Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE>
build-support/bin/protobuf/mac/10.12/2.5.0/protoc:                                                  Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE>
build-support/bin/protobuf/mac/10.12/2.6.1/protoc:                                                  Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE>
build-support/bin/protobuf/mac/10.12/2.4.1/protoc:                                                  Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE>
build-support/scripts/buildozer/mac/10.12/0.6.0.dce8b3c287652cbcaf43c8dd076b3f48c92ab44c/buildozer: Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS>
build-support/scripts/buildozer/mac/10.12/0.4.5/buildozer:                                          Mach-O 64-bit x86_64 executable, flags:<NOUNDEFS>

And the problem tarred-up native distributions:

$ find build-support/ -type f ! -type l | grep -E "/mac/10.1[2-9]/" | grep -E "/(xz|llvm|gcc|clang)/"
build-support/bin/clang/mac/10.13/5.0.1/clang.tar.gz
build-support/bin/clang/mac/10.13/6.0.0/build.sh
build-support/bin/clang/mac/10.13/6.0.0/build-clang.sh
build-support/bin/xz/mac/10.13/5.2.4-1/build.sh
build-support/bin/xz/mac/10.13/5.2.4-1/build-xz.sh
build-support/bin/xz/mac/10.13/5.2.4-3/build.sh
build-support/bin/xz/mac/10.13/5.2.4-3/build-xz.shn
build-support/bin/xz/mac/10.13/5.2.4-2/build.sh
build-support/bin/xz/mac/10.13/5.2.4-2/build-xz.sh
build-support/bin/xz/mac/10.13/5.2.4-2/xz.py
build-support/bin/xz/mac/10.13/5.2.4/build.sh
build-support/bin/xz/mac/10.13/5.2.4/build-xz.sh
build-support/bin/llvm/mac/10.13/6.0.0/build-llvm.sh
build-support/bin/llvm/mac/10.13/6.0.0/build.sh
build-support/bin/gcc/mac/10.13/7.3.0/build-gcc.sh
build-support/bin/gcc/mac/10.13/7.3.0/build.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant