Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Run ng-killall in tearDown to limit memory taken by ng processes
`Abnormal build process termination` in #133 was due to: 1. tests:all using rglobs is getting bigger and bigger 2. More integration tests are added, https://rbcommons.com/s/twitter/r/3819/ added a few previously missed. Now after running some pants commands, ng processes are taking close to the limit [1] and eventually crashed later java process. We have seen this behavior at Twitter in CI where memory is limited. Solution there is to turn on ng only for compile, plus running ng-killall at the very beginning of run (consists serveral subsequent pants test targets). Here added is similar to that, to run ng-killall in `tearDown` as cleanup, at a cost of increasing the overall test time, but that hopefully we can address via #137. Turning off ng is another option, but would rather test more real settings for integration tests. [1] "3GB of memory and up to 2 cores" https://travis-ci.com/plans Testing Done: https://travis-ci.org/peiyuwang/intellij-pants-plugin/builds/128219704 passed https://travis-ci.org/peiyuwang/intellij-pants-plugin/builds/128466370 passed (calling passed whenever I see the first 3 shards succeeded) Bugs closed: 133, 138 Reviewed at https://rbcommons.com/s/twitter/r/3831/
- Loading branch information
Showing
3 changed files
with
22 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters