Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 2018.1 compatibility #335

Merged
merged 14 commits into from Mar 13, 2018
Merged

Conversation

wisechengyi
Copy link
Collaborator

@wisechengyi wisechengyi commented Mar 11, 2018

Also addresses #327

@wisechengyi
Copy link
Collaborator Author

wisechengyi commented Mar 11, 2018

Will merge after #334

@wisechengyi wisechengyi changed the title [wip] upgrade to 2018.1 compatibility Upgrade to 2018.1 compatibility Mar 11, 2018
@wisechengyi
Copy link
Collaborator Author

Plan to merge this by EOD.

@wisechengyi wisechengyi merged commit 59a7e14 into pantsbuild:master Mar 13, 2018
@wisechengyi wisechengyi deleted the 18 branch March 13, 2018 01:13
@sproshev
Copy link

Seems like plugin was published with wrong Compatible builds value

https://plugins.jetbrains.com/plugin/7412-pants-support

@wisechengyi
Copy link
Collaborator Author

@sproshev ah the build number 1.8.1 may be a bit confusing, but it is for 173.x intellij.

Builds for 181.x branch would start 1.9.0 for pants plugin

@sproshev
Copy link

@wisechengyi I see, thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants