Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin pex invocations to kernel interpreter #10

Closed
kwlzn opened this issue Mar 3, 2021 · 0 comments · Fixed by #25
Closed

Pin pex invocations to kernel interpreter #10

kwlzn opened this issue Mar 3, 2021 · 0 comments · Fixed by #25
Assignees
@jsirois
Milestone
1.0

Comments

@kwlzn
Copy link
Member

kwlzn commented Mar 3, 2021 •
edited
Loading

when invoking pex(1), we should ensure that we pass:

--python {sys.executable}

so that the build-time python interpreter and kernel interpreter align 1:1 for uniform build-and-load.

context: #1 (comment)

additionally, if a pants repo target specifies interpreter constraints that do not match the kernel's interpreter we should fail in an elegant and helpful way.

context: #10 (comment)
@kwlzn kwlzn added this to the 1.0 milestone Mar 3, 2021
@jsirois jsirois self-assigned this Mar 5, 2021
@jsirois jsirois added the in progress The issue is actively being worked by an assignee, label Mar 5, 2021
jsirois added a commit to jsirois/pants-jupyter-plugin that referenced this issue Mar 5, 2021
@jsirois
Ensure PEXes are compatible with sys.executable.
9329965 
We now ensure PEX files we create are compatible with the current
interpreter and we also ensure PEX files we're asked to load are as
well; failing with an informative error if not.

Fixes pantsbuild#10
@jsirois jsirois mentioned this issue Mar 5, 2021
Merged
jsirois added a commit that referenced this issue Mar 6, 2021
@jsirois
Ensure PEXes are compatible with sys.executable. (#25)
2cc2532 
We now ensure PEX files we create are compatible with the current
interpreter and we also ensure PEX files we're asked to load are as
well; failing with an informative error if not.

Fixes #10
@jsirois jsirois removed the in progress The issue is actively being worked by an assignee, label Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsirois jsirois

Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Ensure PEXes are compatible with sys.executable. jsirois/pants-jupyter-plugin
2 participants
@jsirois @kwlzn