-
-
Notifications
You must be signed in to change notification settings - Fork 606
/
graph_test.py
1224 lines (1052 loc) · 46.7 KB
/
graph_test.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
# Copyright 2020 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).
import itertools
from dataclasses import dataclass
from pathlib import PurePath
from textwrap import dedent
from typing import Iterable, List, Sequence, Type
import pytest
from pants.base.specs import (
FilesystemGlobSpec,
FilesystemLiteralSpec,
FilesystemMergedSpec,
FilesystemResolvedGlobSpec,
FilesystemSpecs,
SingleAddress,
)
from pants.engine.addresses import Address, Addresses, AddressesWithOrigins, AddressWithOrigin
from pants.engine.fs import (
CreateDigest,
Digest,
DigestContents,
FileContent,
Snapshot,
SourcesSnapshot,
)
from pants.engine.internals.graph import (
AmbiguousCodegenImplementationsException,
AmbiguousImplementationsException,
InvalidFileDependencyException,
NoValidTargetsException,
Owners,
OwnersRequest,
TooManyTargetsException,
parse_dependencies_field,
validate_explicit_file_dep,
)
from pants.engine.internals.scheduler import ExecutionError
from pants.engine.rules import RootRule, rule
from pants.engine.selectors import Get, Params
from pants.engine.target import (
Dependencies,
DependenciesRequest,
FieldSet,
FieldSetWithOrigin,
GeneratedSources,
GenerateSourcesRequest,
HydratedSources,
HydrateSourcesRequest,
InferDependenciesRequest,
InferredDependencies,
InjectDependenciesRequest,
InjectedDependencies,
Sources,
Tags,
Target,
Targets,
TargetsToValidFieldSets,
TargetsToValidFieldSetsRequest,
TargetsWithOrigins,
TargetWithOrigin,
TransitiveTarget,
TransitiveTargets,
WrappedTarget,
)
from pants.engine.unions import UnionMembership, UnionRule, union
from pants.init.specs_calculator import SpecsCalculator
from pants.testutil.option.util import create_options_bootstrapper
from pants.testutil.test_base import TestBase
from pants.util.ordered_set import FrozenOrderedSet
class MockTarget(Target):
alias = "target"
core_fields = (Dependencies, Sources)
class GraphTest(TestBase):
@classmethod
def rules(cls):
return (*super().rules(), RootRule(Addresses), RootRule(WrappedTarget))
@classmethod
def target_types(cls):
return (MockTarget,)
def test_transitive_targets(self) -> None:
self.add_to_build_file(
"",
dedent(
"""\
target(name='t1')
target(name='t2', dependencies=[':t1'])
target(name='d1', dependencies=[':t1'])
target(name='d2', dependencies=[':t2'])
target(name='d3')
target(name='root', dependencies=[':d1', ':d2', ':d3'])
"""
),
)
def get_target(name: str) -> Target:
return self.request_single_product(WrappedTarget, Address.parse(f"//:{name}")).target
t1 = get_target("t1")
t2 = get_target("t2")
d1 = get_target("d1")
d2 = get_target("d2")
d3 = get_target("d3")
root = get_target("root")
direct_deps = self.request_single_product(
Targets, Params(DependenciesRequest(root[Dependencies]), create_options_bootstrapper())
)
assert direct_deps == Targets([d1, d2, d3])
transitive_target = self.request_single_product(
TransitiveTarget, Params(WrappedTarget(root), create_options_bootstrapper())
)
assert transitive_target.root == root
assert {
dep_transitive_target.root for dep_transitive_target in transitive_target.dependencies
} == {d1, d2, d3}
transitive_targets = self.request_single_product(
TransitiveTargets,
Params(Addresses([root.address, d2.address]), create_options_bootstrapper()),
)
assert transitive_targets.roots == (root, d2)
# NB: `//:d2` is both a target root and a dependency of `//:root`.
assert transitive_targets.dependencies == FrozenOrderedSet([d1, d2, d3, t2, t1])
assert transitive_targets.closure == FrozenOrderedSet([root, d2, d1, d3, t2, t1])
def test_resolve_generated_subtarget(self) -> None:
self.add_to_build_file("demo", "target(sources=['f1.txt', 'f2.txt'])")
generated_target_addresss = Address(
"demo", target_name="f1.txt", generated_base_target_name="demo"
)
generated_target = self.request_single_product(
WrappedTarget, generated_target_addresss
).target
assert generated_target == MockTarget(
{Sources.alias: ["f1.txt"]}, address=generated_target_addresss
)
def test_resolve_sources_snapshot(self) -> None:
"""This tests that convert filesystem specs and/or address specs into a single snapshot.
Some important edge cases:
- When a filesystem spec refers to a file without any owning target, it should be included
in the snapshot.
- If a file is covered both by an address spec and by a filesystem spec, we should merge it
so that the file only shows up once.
"""
self.create_files("demo", ["f1.txt", "f2.txt"])
self.add_to_build_file("demo", "target(sources=['*.txt'])")
specs = SpecsCalculator.parse_specs(["demo:demo", "demo/f1.txt", "demo/BUILD"])
result = self.request_single_product(
SourcesSnapshot, Params(specs, create_options_bootstrapper())
)
assert result.snapshot.files == ("demo/BUILD", "demo/f1.txt", "demo/f2.txt")
class TestOwners(TestBase):
@classmethod
def target_types(cls):
return (MockTarget,)
def test_owners_source_file_does_not_exist(self) -> None:
"""Test when a source file belongs to a target, even though the file does not actually
exist.
This happens, for example, when the file is deleted and we're computing `--changed-since`.
In this case, we should not attempt to generate a subtarget and should use the original
target.
"""
self.create_file("demo/f.txt")
self.add_to_build_file("demo", "target(sources=['*.txt'])")
result = self.request_single_product(Owners, OwnersRequest(("demo/deleted.txt",)))
assert result == Owners([Address("demo", "demo")])
# For files that do exist, we should still use a generated subtarget, though.
result = self.request_single_product(Owners, OwnersRequest(("demo/f.txt",)))
assert result == Owners(
[Address("demo", target_name="f.txt", generated_base_target_name="demo")]
)
# However, if a sibling file must use the original target, then we should always use
# the original target to avoid redundancy.
result = self.request_single_product(
Owners, OwnersRequest(("demo/f.txt", "demo/deleted.txt"))
)
assert result == Owners([Address("demo", "demo")])
def test_owners_multiple_owners(self) -> None:
"""This tests that we do not use generated subtargets when there are multiple owners.
There are two edge cases:
- There are >1 owners of the file in question.
- The file in question only has one owner, but its sibling from the same target does have
>1 owner. In this case, we use the original owning target because it would be
redundant to include the generated subtarget.
"""
self.create_files("demo", ["f1.txt", "f2.txt"])
self.add_to_build_file(
"demo",
dedent(
"""\
target(name='all', sources=['*.txt'])
target(name='f2', sources=['f2.txt'])
"""
),
)
one_owner_result = self.request_single_product(Owners, OwnersRequest(("demo/f1.txt",)))
assert one_owner_result == Owners(
[Address("demo", target_name="f1.txt", generated_base_target_name="all")]
)
two_owners_result = self.request_single_product(Owners, OwnersRequest(("demo/f2.txt",)))
assert two_owners_result == Owners([Address("demo", "f2"), Address("demo", "all")])
sibling_has_two_owners_result = self.request_single_product(
Owners, OwnersRequest(("demo/f1.txt", "demo/f2.txt"))
)
assert sibling_has_two_owners_result == Owners(
[Address("demo", "f2"), Address("demo", "all")]
)
def test_owners_build_file(self) -> None:
"""A BUILD file owns every target defined in it.
This must also respect the general rules for when to use generated subtargets vs. the
original owning target. See `test_owners_multiple_owners`.
"""
self.create_files("demo", ["f1.txt", "f2.txt"])
self.add_to_build_file(
"demo",
dedent(
"""\
target(name='f1', sources=['f1.txt'])
target(name='f2_first', sources=['f2.txt'])
target(name='f2_second', sources=['f2.txt'])
"""
),
)
result = self.request_single_product(Owners, OwnersRequest(("demo/BUILD",)))
assert set(result) == {
Address("demo", target_name="f1.txt", generated_base_target_name="f1"),
Address("demo", "f2_first"),
Address("demo", "f2_second"),
}
class TestSpecsToAddresses(TestBase):
@classmethod
def rules(cls):
return (*super().rules(), RootRule(Addresses), RootRule(FilesystemSpecs))
@classmethod
def target_types(cls):
return (MockTarget,)
def test_filesystem_specs_literal_file(self) -> None:
self.create_files("demo", ["f1.txt", "f2.txt"])
self.add_to_build_file("demo", "target(sources=['*.txt'])")
spec = FilesystemLiteralSpec("demo/f1.txt")
result = self.request_single_product(
AddressesWithOrigins, Params(FilesystemSpecs([spec]), create_options_bootstrapper())
)
assert len(result) == 1
assert result[0] == AddressWithOrigin(
Address("demo", target_name="f1.txt", generated_base_target_name="demo"), origin=spec
)
def test_filesystem_specs_glob(self) -> None:
self.create_files("demo", ["f1.txt", "f2.txt"])
self.add_to_build_file("demo", "target(sources=['*.txt'])")
result = self.request_single_product(
AddressesWithOrigins,
Params(
FilesystemSpecs([FilesystemGlobSpec("demo/*.txt")]), create_options_bootstrapper()
),
)
expected_origin = FilesystemResolvedGlobSpec(
glob="demo/*.txt", files=("demo/f1.txt", "demo/f2.txt")
)
assert result == AddressesWithOrigins(
[
AddressWithOrigin(
Address("demo", target_name="f1.txt", generated_base_target_name="demo"),
origin=expected_origin,
),
AddressWithOrigin(
Address("demo", target_name="f2.txt", generated_base_target_name="demo"),
origin=expected_origin,
),
]
)
def test_filesystem_specs_merge_when_same_address(self) -> None:
"""Test that two filesystem specs resulting in the same address will merge into one result.
This is a tricky edge case to trigger. First, we must be using the original owning targets,
rather than generated subtargets, which means that there must be multiple owning targets.
Then, we must have two specs that resulted in the same original address.
"""
self.create_files("demo", ["f1.txt", "f2.txt"])
self.add_to_build_file(
"demo",
dedent(
"""\
target(name='one', sources=['*.txt'])
target(name='two', sources=['*.txt'])
"""
),
)
specs = [FilesystemLiteralSpec("demo/f1.txt"), FilesystemLiteralSpec("demo/f2.txt")]
result = self.request_single_product(
AddressesWithOrigins, Params(FilesystemSpecs(specs), create_options_bootstrapper())
)
expected_origin = FilesystemMergedSpec.create(specs)
assert result == AddressesWithOrigins(
[
AddressWithOrigin(Address("demo", "two"), expected_origin),
AddressWithOrigin(Address("demo", "one"), expected_origin),
]
)
def test_filesystem_specs_nonexistent_file(self) -> None:
specs = FilesystemSpecs([FilesystemLiteralSpec("demo/fake.txt")])
with pytest.raises(ExecutionError) as exc:
self.request_single_product(
AddressesWithOrigins, Params(specs, create_options_bootstrapper()),
)
assert 'Unmatched glob from file arguments: "demo/fake.txt"' in str(exc.value)
ignore_errors_result = self.request_single_product(
AddressesWithOrigins,
Params(specs, create_options_bootstrapper(args=["--owners-not-found-behavior=ignore"])),
)
assert not ignore_errors_result
def test_filesystem_specs_no_owner(self) -> None:
self.create_file("no_owners/f.txt")
# Error for literal specs.
with pytest.raises(ExecutionError) as exc:
self.request_single_product(
AddressesWithOrigins,
Params(
FilesystemSpecs([FilesystemLiteralSpec("no_owners/f.txt")]),
create_options_bootstrapper(),
),
)
assert "No owning targets could be found for the file `no_owners/f.txt`" in str(exc.value)
# Do not error for glob specs.
glob_file_result = self.request_single_product(
AddressesWithOrigins,
Params(
FilesystemSpecs([FilesystemGlobSpec("no_owners/*.txt")]),
create_options_bootstrapper(),
),
)
assert not glob_file_result
def test_resolve_addresses(self) -> None:
"""This tests that we correctly merge addresses resolved from address specs with those
resolved from filesystem specs.
Some important edge cases:
- If a filesystem spec resulted in a normal target, and that target is already in the
address specs, then we should deduplicate to only use the target one time.
- If a filesystem spec resulted in a generated subtarget, and that subtarget is generated
from an original target that is already in the address specs, then we should not use the
generated subtarget.
"""
self.create_file("fs_spec/f.txt")
self.add_to_build_file("fs_spec", "target(sources=['f.txt'])")
self.create_file("address_spec/f.txt")
self.add_to_build_file("address_spec", "target(sources=['f.txt'])")
no_interaction_specs = ["fs_spec/f.txt", "address_spec:address_spec"]
# Because there are two owners, using a filesystem spec on this should result in both
# original targets being used, rather than generated subtargets. If we also use an address
# spec on one of those two owners, then we should properly dedupe with the filesystem spec
# result.
self.create_file("two_owners/f.txt")
self.add_to_build_file(
"two_owners",
dedent(
"""\
target(name='one', sources=['f.txt'])
target(name='two', sources=['f.txt'])
"""
),
)
two_owners_specs = ["two_owners/f.txt", "two_owners:one"]
# If a generated subtarget's original base target is already included via an address spec,
# then we should not include the generated subtarget because it would be redundant.
self.create_files("multiple_files", ["f1.txt", "f2.txt"])
self.add_to_build_file("multiple_files", "target(sources=['*.txt'])")
multiple_files_specs = ["multiple_files/f2.txt", "multiple_files:multiple_files"]
specs = SpecsCalculator.parse_specs(
[*no_interaction_specs, *two_owners_specs, *multiple_files_specs]
)
result = self.request_single_product(
AddressesWithOrigins, Params(specs, create_options_bootstrapper())
)
assert set(result) == {
AddressWithOrigin(
Address("fs_spec", target_name="f.txt", generated_base_target_name="fs_spec"),
origin=FilesystemLiteralSpec("fs_spec/f.txt"),
),
AddressWithOrigin(
Address("address_spec", "address_spec"),
origin=SingleAddress("address_spec", "address_spec"),
),
AddressWithOrigin(
Address("two_owners", "one"), origin=SingleAddress("two_owners", "one")
),
AddressWithOrigin(
Address("two_owners", "two"), origin=FilesystemLiteralSpec("two_owners/f.txt"),
),
AddressWithOrigin(
Address("multiple_files", "multiple_files"),
origin=SingleAddress("multiple_files", "multiple_files"),
),
}
# -----------------------------------------------------------------------------------------------
# Test FieldSets. Also see `engine/target_test.py`.
# -----------------------------------------------------------------------------------------------
class FortranSources(Sources):
pass
class FortranTarget(Target):
alias = "fortran_target"
core_fields = (FortranSources, Tags)
class TestFindValidFieldSets(TestBase):
class InvalidTarget(Target):
alias = "invalid_target"
core_fields = ()
@classmethod
def target_types(cls):
return [FortranTarget, cls.InvalidTarget]
@union
class FieldSetSuperclass(FieldSet):
pass
@dataclass(frozen=True)
class FieldSetSubclass1(FieldSetSuperclass):
required_fields = (FortranSources,)
sources: FortranSources
@dataclass(frozen=True)
class FieldSetSubclass2(FieldSetSuperclass):
required_fields = (FortranSources,)
sources: FortranSources
@union
class FieldSetSuperclassWithOrigin(FieldSetWithOrigin):
pass
class FieldSetSubclassWithOrigin(FieldSetSuperclassWithOrigin):
required_fields = (FortranSources,)
sources: FortranSources
@classmethod
def rules(cls):
return (
*super().rules(),
RootRule(TargetsWithOrigins),
UnionRule(cls.FieldSetSuperclass, cls.FieldSetSubclass1),
UnionRule(cls.FieldSetSuperclass, cls.FieldSetSubclass2),
UnionRule(cls.FieldSetSuperclassWithOrigin, cls.FieldSetSubclassWithOrigin),
)
def test_find_valid_field_sets(self) -> None:
origin = FilesystemLiteralSpec("f.txt")
valid_tgt = FortranTarget({}, address=Address.parse(":valid"))
valid_tgt_with_origin = TargetWithOrigin(valid_tgt, origin)
invalid_tgt = self.InvalidTarget({}, address=Address.parse(":invalid"))
invalid_tgt_with_origin = TargetWithOrigin(invalid_tgt, origin)
def find_valid_field_sets(
superclass: Type,
targets_with_origins: Iterable[TargetWithOrigin],
*,
error_if_no_valid_targets: bool = False,
expect_single_config: bool = False,
) -> TargetsToValidFieldSets:
request = TargetsToValidFieldSetsRequest(
superclass,
goal_description="fake",
error_if_no_valid_targets=error_if_no_valid_targets,
expect_single_field_set=expect_single_config,
)
return self.request_single_product(
TargetsToValidFieldSets, Params(request, TargetsWithOrigins(targets_with_origins),),
)
valid = find_valid_field_sets(
self.FieldSetSuperclass, [valid_tgt_with_origin, invalid_tgt_with_origin]
)
assert valid.targets == (valid_tgt,)
assert valid.targets_with_origins == (valid_tgt_with_origin,)
assert valid.field_sets == (
self.FieldSetSubclass1.create(valid_tgt),
self.FieldSetSubclass2.create(valid_tgt),
)
with pytest.raises(ExecutionError) as exc:
find_valid_field_sets(
self.FieldSetSuperclass, [valid_tgt_with_origin], expect_single_config=True
)
assert AmbiguousImplementationsException.__name__ in str(exc.value)
with pytest.raises(ExecutionError) as exc:
find_valid_field_sets(
self.FieldSetSuperclass,
[
valid_tgt_with_origin,
TargetWithOrigin(FortranTarget({}, address=Address.parse(":valid2")), origin),
],
expect_single_config=True,
)
assert TooManyTargetsException.__name__ in str(exc.value)
no_valid_targets = find_valid_field_sets(self.FieldSetSuperclass, [invalid_tgt_with_origin])
assert no_valid_targets.targets == ()
assert no_valid_targets.targets_with_origins == ()
assert no_valid_targets.field_sets == ()
with pytest.raises(ExecutionError) as exc:
find_valid_field_sets(
self.FieldSetSuperclass, [invalid_tgt_with_origin], error_if_no_valid_targets=True
)
assert NoValidTargetsException.__name__ in str(exc.value)
valid_with_origin = find_valid_field_sets(
self.FieldSetSuperclassWithOrigin, [valid_tgt_with_origin, invalid_tgt_with_origin]
)
assert valid_with_origin.targets == (valid_tgt,)
assert valid_with_origin.targets_with_origins == (valid_tgt_with_origin,)
assert valid_with_origin.field_sets == (
self.FieldSetSubclassWithOrigin.create(valid_tgt_with_origin),
)
# -----------------------------------------------------------------------------------------------
# Test the Sources field, including codegen. Also see `engine/target_test.py`.
# -----------------------------------------------------------------------------------------------
class TestSources(TestBase):
@classmethod
def rules(cls):
return (*super().rules(), RootRule(HydrateSourcesRequest))
def test_normal_hydration(self) -> None:
addr = Address.parse("src/fortran:lib")
self.create_files("src/fortran", files=["f1.f95", "f2.f95", "f1.f03", "ignored.f03"])
sources = Sources(["f1.f95", "*.f03", "!ignored.f03", "!**/ignore*"], address=addr)
hydrated_sources = self.request_single_product(
HydratedSources, HydrateSourcesRequest(sources)
)
assert hydrated_sources.snapshot.files == ("src/fortran/f1.f03", "src/fortran/f1.f95")
# Also test that the Filespec is correct. This does not need hydration to be calculated.
assert (
sources.filespec
== {
"includes": ["src/fortran/*.f03", "src/fortran/f1.f95"],
"excludes": ["src/fortran/**/ignore*", "src/fortran/ignored.f03"],
}
== hydrated_sources.filespec
)
def test_output_type(self) -> None:
class SourcesSubclass(Sources):
pass
addr = Address.parse(":lib")
self.create_files("", files=["f1.f95"])
valid_sources = SourcesSubclass(["*"], address=addr)
hydrated_valid_sources = self.request_single_product(
HydratedSources,
HydrateSourcesRequest(valid_sources, for_sources_types=[SourcesSubclass]),
)
assert hydrated_valid_sources.snapshot.files == ("f1.f95",)
assert hydrated_valid_sources.sources_type == SourcesSubclass
invalid_sources = Sources(["*"], address=addr)
hydrated_invalid_sources = self.request_single_product(
HydratedSources,
HydrateSourcesRequest(invalid_sources, for_sources_types=[SourcesSubclass]),
)
assert hydrated_invalid_sources.snapshot.files == ()
assert hydrated_invalid_sources.sources_type is None
def test_unmatched_globs(self) -> None:
self.create_files("", files=["f1.f95"])
sources = Sources(["non_existent.f95"], address=Address.parse(":lib"))
with pytest.raises(ExecutionError) as exc:
self.request_single_product(HydratedSources, HydrateSourcesRequest(sources))
assert "Unmatched glob" in str(exc.value)
assert "//:lib" in str(exc.value)
assert "non_existent.f95" in str(exc.value)
def test_default_globs(self) -> None:
class DefaultSources(Sources):
default = ("default.f95", "default.f03", "*.f08", "!ignored.f08")
addr = Address.parse("src/fortran:lib")
# NB: Not all globs will be matched with these files, specifically `default.f03` will not
# be matched. This is intentional to ensure that we use `any` glob conjunction rather
# than the normal `all` conjunction.
self.create_files("src/fortran", files=["default.f95", "f1.f08", "ignored.f08"])
sources = DefaultSources(None, address=addr)
assert set(sources.sanitized_raw_value or ()) == set(DefaultSources.default)
hydrated_sources = self.request_single_product(
HydratedSources, HydrateSourcesRequest(sources)
)
assert hydrated_sources.snapshot.files == ("src/fortran/default.f95", "src/fortran/f1.f08")
def test_expected_file_extensions(self) -> None:
class ExpectedExtensionsSources(Sources):
expected_file_extensions = (".f95", ".f03")
addr = Address.parse("src/fortran:lib")
self.create_files("src/fortran", files=["s.f95", "s.f03", "s.f08"])
sources = ExpectedExtensionsSources(["s.f*"], address=addr)
with pytest.raises(ExecutionError) as exc:
self.request_single_product(HydratedSources, HydrateSourcesRequest(sources))
assert "s.f08" in str(exc.value)
assert str(addr) in str(exc.value)
# Also check that we support valid sources
valid_sources = ExpectedExtensionsSources(["s.f95"], address=addr)
assert self.request_single_product(
HydratedSources, HydrateSourcesRequest(valid_sources)
).snapshot.files == ("src/fortran/s.f95",)
def test_expected_num_files(self) -> None:
class ExpectedNumber(Sources):
expected_num_files = 2
class ExpectedRange(Sources):
# We allow for 1 or 3 files
expected_num_files = range(1, 4, 2)
self.create_files("", files=["f1.txt", "f2.txt", "f3.txt", "f4.txt"])
def hydrate(sources_cls: Type[Sources], sources: Iterable[str]) -> HydratedSources:
return self.request_single_product(
HydratedSources,
HydrateSourcesRequest(sources_cls(sources, address=Address.parse(":example"))),
)
with pytest.raises(ExecutionError) as exc:
hydrate(ExpectedNumber, [])
assert "must have 2 files" in str(exc.value)
with pytest.raises(ExecutionError) as exc:
hydrate(ExpectedRange, ["f1.txt", "f2.txt"])
assert "must have 1 or 3 files" in str(exc.value)
# Also check that we support valid # files.
assert hydrate(ExpectedNumber, ["f1.txt", "f2.txt"]).snapshot.files == ("f1.txt", "f2.txt")
assert hydrate(ExpectedRange, ["f1.txt"]).snapshot.files == ("f1.txt",)
assert hydrate(ExpectedRange, ["f1.txt", "f2.txt", "f3.txt"]).snapshot.files == (
"f1.txt",
"f2.txt",
"f3.txt",
)
class SmalltalkSources(Sources):
pass
class AvroSources(Sources):
pass
class AvroLibrary(Target):
alias = "avro_library"
core_fields = (AvroSources,)
class GenerateSmalltalkFromAvroRequest(GenerateSourcesRequest):
input = AvroSources
output = SmalltalkSources
@rule
async def generate_smalltalk_from_avro(
request: GenerateSmalltalkFromAvroRequest,
) -> GeneratedSources:
protocol_files = request.protocol_sources.files
def generate_fortran(fp: str) -> FileContent:
parent = str(PurePath(fp).parent).replace("src/avro", "src/smalltalk")
file_name = f"{PurePath(fp).stem}.st"
return FileContent(str(PurePath(parent, file_name)), b"Generated")
result = await Get(Snapshot, CreateDigest([generate_fortran(fp) for fp in protocol_files]))
return GeneratedSources(result)
class TestCodegen(TestBase):
@classmethod
def rules(cls):
return (
*super().rules(),
generate_smalltalk_from_avro,
RootRule(GenerateSmalltalkFromAvroRequest),
RootRule(HydrateSourcesRequest),
UnionRule(GenerateSourcesRequest, GenerateSmalltalkFromAvroRequest),
)
@classmethod
def target_types(cls):
return [AvroLibrary]
def setUp(self) -> None:
self.address = Address.parse("src/avro:lib")
self.create_files("src/avro", files=["f.avro"])
self.add_to_build_file("src/avro", "avro_library(name='lib', sources=['*.avro'])")
self.union_membership = self.request_single_product(UnionMembership, Params())
def test_generate_sources(self) -> None:
protocol_sources = AvroSources(["*.avro"], address=self.address)
assert protocol_sources.can_generate(SmalltalkSources, self.union_membership) is True
# First, get the original protocol sources.
hydrated_protocol_sources = self.request_single_product(
HydratedSources, HydrateSourcesRequest(protocol_sources)
)
assert hydrated_protocol_sources.snapshot.files == ("src/avro/f.avro",)
# Test directly feeding the protocol sources into the codegen rule.
wrapped_tgt = self.request_single_product(WrappedTarget, self.address)
generated_sources = self.request_single_product(
GeneratedSources,
GenerateSmalltalkFromAvroRequest(
hydrated_protocol_sources.snapshot, wrapped_tgt.target
),
)
assert generated_sources.snapshot.files == ("src/smalltalk/f.st",)
# Test that HydrateSourcesRequest can also be used.
generated_via_hydrate_sources = self.request_single_product(
HydratedSources,
HydrateSourcesRequest(
protocol_sources, for_sources_types=[SmalltalkSources], enable_codegen=True
),
)
assert generated_via_hydrate_sources.snapshot.files == ("src/smalltalk/f.st",)
assert generated_via_hydrate_sources.sources_type == SmalltalkSources
def test_works_with_subclass_fields(self) -> None:
class CustomAvroSources(AvroSources):
pass
protocol_sources = CustomAvroSources(["*.avro"], address=self.address)
assert protocol_sources.can_generate(SmalltalkSources, self.union_membership) is True
generated = self.request_single_product(
HydratedSources,
HydrateSourcesRequest(
protocol_sources, for_sources_types=[SmalltalkSources], enable_codegen=True
),
)
assert generated.snapshot.files == ("src/smalltalk/f.st",)
def test_cannot_generate_language(self) -> None:
class AdaSources(Sources):
pass
protocol_sources = AvroSources(["*.avro"], address=self.address)
assert protocol_sources.can_generate(AdaSources, self.union_membership) is False
generated = self.request_single_product(
HydratedSources,
HydrateSourcesRequest(
protocol_sources, for_sources_types=[AdaSources], enable_codegen=True
),
)
assert generated.snapshot.files == ()
assert generated.sources_type is None
def test_ambiguous_implementations_exception(self) -> None:
# This error message is quite complex. We test that it correctly generates the message.
class SmalltalkGenerator1(GenerateSourcesRequest):
input = AvroSources
output = SmalltalkSources
class SmalltalkGenerator2(GenerateSourcesRequest):
input = AvroSources
output = SmalltalkSources
class AdaSources(Sources):
pass
class AdaGenerator(GenerateSourcesRequest):
input = AvroSources
output = AdaSources
class IrrelevantSources(Sources):
pass
# Test when all generators have the same input and output.
exc = AmbiguousCodegenImplementationsException(
[SmalltalkGenerator1, SmalltalkGenerator2], for_sources_types=[SmalltalkSources]
)
assert "can generate SmalltalkSources from AvroSources" in str(exc)
assert "* SmalltalkGenerator1" in str(exc)
assert "* SmalltalkGenerator2" in str(exc)
# Test when the generators have different input and output, which usually happens because
# the call site used too expansive of a `for_sources_types` argument.
exc = AmbiguousCodegenImplementationsException(
[SmalltalkGenerator1, AdaGenerator],
for_sources_types=[SmalltalkSources, AdaSources, IrrelevantSources],
)
assert "can generate one of ['AdaSources', 'SmalltalkSources'] from AvroSources" in str(exc)
assert "IrrelevantSources" not in str(exc)
assert "* SmalltalkGenerator1 -> SmalltalkSources" in str(exc)
assert "* AdaGenerator -> AdaSources" in str(exc)
# -----------------------------------------------------------------------------------------------
# Test the Dependencies field. Also see `engine/target_test.py`.
# -----------------------------------------------------------------------------------------------
def test_parse_dependencies_field() -> None:
given_values = [
":relative",
"//:top_level",
"demo:tgt",
"demo",
"./relative.txt",
"./child/f.txt",
"demo/f.txt",
"//top_level.txt",
"top_level2.txt",
# For files without an extension, you must use `./` There is no way (yet) to reference
# a file above you without a file extension.
"demo/no_extension",
"//demo/no_extension",
"./no_extension",
]
result = parse_dependencies_field(
[*given_values, *(f"!{v}" for v in given_values)],
spec_path="demo/subdir",
subproject_roots=[],
)
expected_addresses = {
Address("demo/subdir", "relative"),
Address("", "top_level"),
Address("demo", "tgt"),
Address("demo", "demo"),
Address("demo/no_extension", "no_extension"),
}
assert set(result.addresses) == expected_addresses
assert set(result.ignored_addresses) == expected_addresses
expected_files = {
"demo/subdir/relative.txt",
"demo/subdir/child/f.txt",
"demo/f.txt",
"top_level.txt",
"top_level2.txt",
"demo/subdir/no_extension",
}
assert set(result.files) == expected_files
assert set(result.ignored_files) == expected_files
def test_validate_explicit_file_dep() -> None:
addr = Address("demo", "tgt")
def assert_raises(
owners: Sequence[Address], *, expected_snippets: Iterable[str], is_an_ignore: bool = False
) -> None:
with pytest.raises(InvalidFileDependencyException) as exc:
validate_explicit_file_dep(
addr, full_file="f.txt", owners=owners, is_an_ignore=is_an_ignore
)
assert addr.spec in str(exc.value)
if is_an_ignore:
assert "!f.txt" in str(exc.value)
else:
assert "f.txt" in str(exc.value)
for snippet in expected_snippets:
assert snippet in str(exc.value)
assert_raises(owners=[], expected_snippets=["no owners"])
assert_raises(owners=[], is_an_ignore=True, expected_snippets=["no owners"])
# Even if there is one owner, if it was not generated, then we fail because we can assume that
# the file in question does not actually exist.
assert_raises(owners=[Address.parse(":t")], expected_snippets=["no owners"])
assert_raises(owners=[Address.parse(":t")], is_an_ignore=True, expected_snippets=["no owners"])
assert_raises(
owners=[Address.parse(":t1"), Address.parse(":t2")],
expected_snippets=["multiple owners", "//:t1", "//:t2"],
)
assert_raises(
owners=[Address.parse(":t1"), Address.parse(":t2")],
is_an_ignore=True,
expected_snippets=["multiple owners", "!//:t1", "!//:t2"],
)
# Do not raise if there is one single generated owner.
validate_explicit_file_dep(
addr,
full_file="f.txt",
owners=[Address("", target_name="f.txt", generated_base_target_name="demo")],
)
validate_explicit_file_dep(
addr,
full_file="f.txt",
owners=[Address("", target_name="f.txt", generated_base_target_name="demo")],
is_an_ignore=True,
)
class SmalltalkDependencies(Dependencies):
pass
class CustomSmalltalkDependencies(SmalltalkDependencies):
pass
class InjectSmalltalkDependencies(InjectDependenciesRequest):
inject_for = SmalltalkDependencies
class InjectCustomSmalltalkDependencies(InjectDependenciesRequest):
inject_for = CustomSmalltalkDependencies
@rule
def inject_smalltalk_deps(_: InjectSmalltalkDependencies) -> InjectedDependencies:
return InjectedDependencies([Address.parse("//:injected1"), Address.parse("//:injected2")])
@rule
def inject_custom_smalltalk_deps(_: InjectCustomSmalltalkDependencies) -> InjectedDependencies:
return InjectedDependencies([Address.parse("//:custom_injected")])
class SmalltalkLibrarySources(SmalltalkSources):
pass
class SmalltalkLibrary(Target):
alias = "smalltalk"
core_fields = (Dependencies, SmalltalkLibrarySources)
class InferSmalltalkDependencies(InferDependenciesRequest):
infer_from = SmalltalkSources
@rule
async def infer_smalltalk_dependencies(request: InferSmalltalkDependencies) -> InferredDependencies:
# To demo an inference rule, we simply treat each `sources` file to contain a list of
# addresses, one per line.
hydrated_sources = await Get(HydratedSources, HydrateSourcesRequest(request.sources_field))
digest_contents = await Get(DigestContents, Digest, hydrated_sources.snapshot.digest)
all_lines = itertools.chain.from_iterable(
file_content.content.decode().splitlines() for file_content in digest_contents
)
def infer(line: str) -> Address:
# To simulate generated subtargets, we look for the format: `file_name.st from :address`
if " from " in line:
gen_name, _, base_address_str = line.split()
base_address = Address.parse(base_address_str)
return Address(
spec_path="",
target_name=gen_name,
generated_base_target_name=base_address.target_name,
)
return Address.parse(line)