Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for consuming shell_source through pants run/adhoc_tool #18321

Open
chrisjrn opened this issue Feb 21, 2023 · 0 comments
Open

Add support for consuming shell_source through pants run/adhoc_tool #18321

chrisjrn opened this issue Feb 21, 2023 · 0 comments
Labels
backend: Shell Shell backend-related issues enhancement

Comments

@chrisjrn
Copy link
Contributor

Currently, shell_command is the only way to run shell code as a build step. While it's possible to add a shell_source as a dependency and make the command string simply run the dependency, in practice it encourages writing multi-line shell scripts in BUILD files, where they can't be checked with linters/formatters/testing tools.

Instead, we should support running shell_source targets through adhoc_tool.

Note that this will require adding some sort of support for the tools field, probably on shell_source itself. Work done in #18168 should make this easy enough to implement, but it would also fall out of a good solution to #18320.

@chrisjrn chrisjrn added category:new feature backend: Swift Swift backend-related issues enhancement backend: Shell Shell backend-related issues and removed category:new feature backend: Swift Swift backend-related issues labels Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Shell Shell backend-related issues enhancement
Projects
None yet
Development

No branches or pull requests

1 participant