Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create context jars for javac invocations remotely when using the hermetic exec strategy #6045

Closed
baroquebobcat opened this issue Jun 28, 2018 · 1 comment

Comments

@baroquebobcat
Copy link
Contributor

creating the z.jar files is part of the work for compiling java or scala sources. That work should also be happening in the hermetic context. With the implementation in #5999, the remote exec calls javac directly and creating the context jar happens in jvm_compile at

Instead of doing that work there, we'd want it to be done by the binary that's invoked by the hermetic execution. That would require a shell script or something that bundles up the class files.

@stuhood
Copy link
Sponsor Member

stuhood commented Jul 26, 2018

Whoops. Thought that this was the work that Ity did in #6094. Related... but that was for zinc.

@benjyw benjyw closed this as completed Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants