You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Eric-Arellano Is this still an issue? I'm testing out adding 'mypyc' support and the easiest way is an extension module in setup.py of the python_distribution.
In https://github.com/pantsbuild/pants/pull/7235/files#diff-3ce39309d74098493a1f3c8107292a8d, we realized we have to add
ext_modules
to the PantsPythonArtifact
so that its ABI gets properly resolved.However, we are doing this using the deprecated tuple syntax, rather than using the expected Extension interface. See https://docs.python.org/3/distutils/setupscript.html#describing-extension-modules for what this should look like.
--
To land this fix, we will need to add first class support in
python_artifact.py
forExtension
andext_modules
.cc @jsirois
The text was updated successfully, but these errors were encountered: