Add support for long_description_path field in python_distribution #14448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Comment on lines
+571
to
+572
| f"the {LongDescriptionPathField.alias} " | ||
| f"field of {exported_target.target.address}" |
There was a problem hiding this comment.
This is how the error message is shown when a non-existing file is passed:
Unmatched glob from the long_description_path field of src/python/foo:foo-dist: "src/python/foo/readme.md"
Eric-Arellano
approved these changes
Feb 12, 2022
There was a problem hiding this comment.
Yay! @jsirois if you're willing to wait, it would be great to include this in today's dev release.
|
cc @asherf , I think this was your original feature request :) |
|
YAY!!!! |
alexey-tereshenkov-oxb
deleted the
python_distribution/add-long_description_path-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #11554
Closed #11554
The rule
determine_setup_kwargsdetermines thekwargsthat are either hardcoded inprovides,or that are provided by the user's plugin for it. TheseSetupKwargswon't have everything, only the foundation for theFinalizedSetupKwargs.We've decided to add the logic of extraction of the long_description file contents here, inside the rule
generate_setup_py_kwargsthat returnsFinalizedSetupKwargs. That will make sure that this new logic works regardless of if you're using a plugin hook or not.