Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank top-level 404 page #84

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fix blank top-level 404 page #84

merged 1 commit into from
Jan 11, 2024

Conversation

thejcannon
Copy link
Member

Fixes #7 in an unfortunately clever, yet still appropriate way.

See the comment in src/js/docsPluginWithTopLevel404.js for greater detail.

Tests:

Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interest! It's not the worst; happy to try it for now.

I tested some extra URLs, e.g. embedded within the docs http://localhost:3000/2.20/reference/wrong

@thejcannon thejcannon merged commit 3ddb2eb into main Jan 11, 2024
1 check passed
@thejcannon thejcannon deleted the jcannon/fix404 branch January 11, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure 404 page is visible for all wrong URLs
2 participants