Mock PATH for problematic interpreter selection test in CI #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
May 13, 2018 12:05
CMLivingston
changed the title
|
@kwlzn This is ready for a look when you can. The only remaining issue is that the refactored interpreter test helper is failing on the pypy shard with a buffer overflow error. Not sure about what could be causing it...do you have any ideas? |
kwlzn
reviewed
May 14, 2018
.travis.yml
Outdated
| # The pypy test shard fails with "too many open files" under Trusty so we pin to Precise. | ||
| dist: precise | ||
| dist: trusty |
There was a problem hiding this comment.
would probably be better to make this change in a separate PR, I think.
| res.assert_success() | ||
| pex_info = get_pex_info(pex_out_path) | ||
| assert ['>3'] == pex_info.interpreter_constraints | ||
| py3_interpreter = ensure_python_interpreter('3.6.3') |
There was a problem hiding this comment.
rather than mocking out os.getenv here, how about just temporarily setting the PATH env var with twitter.common.contextutil.environment_as for the scope of this test?
| @@ -343,17 +349,19 @@ def test_interpreter_constraints_to_pex_info_py2(): | |||
| assert set(['>=2.7', '<3']) == set(pex_info.interpreter_constraints) | |||
|
|
|||
|
|
|||
| @pytest.mark.skip('https://github.com/pantsbuild/pex/issues/470') | |||
| def test_interpreter_constraints_to_pex_info_py3(): | |||
There was a problem hiding this comment.
test_pex_python in test_integration.py needs the same treatment as this test - both were disabled.
This was referenced May 14, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470.