Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support -c for plat spec dists in multiplat pexes. #545

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Support -c for plat spec dists in multiplat pexes. #545

merged 2 commits into from
Aug 28, 2018

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Aug 25, 2018

Fixes #537

@jsirois
Copy link
Member Author

jsirois commented Aug 26, 2018

Eeenteresting. So setuptools 36.2.0+ take install_requires with environment markers and move them to anonymous extras_requires: see here). This 'feature' is only documented here in the wheel docs. I'll back off the un-needed requirement upgrades - just a pytest bump was needed - and file an issue to handle this new wrinkle.

illicitonion
illicitonion approved these changes Aug 28, 2018
View reviewed changes
Copy link
Contributor

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jsirois jsirois merged commit 983589a into pex-tool:master Aug 28, 2018
@jsirois jsirois deleted the issues/537 branch August 28, 2018 17:25
@di di mentioned this pull request Sep 25, 2018
Closed
2 tasks
jsirois added a commit to jsirois/pants that referenced this pull request Oct 11, 2018
@jsirois
Simplify pants.pex creation, leverage -c.
a211e92 
This lets the full entry-point live in less places. The `pants` console
script will be much more stable and it's easy to remember / ~obviously
right.

I forgot to leverage the work in
pex-tool/pex#545 when upgrading from
pex 1.4.5 to 1.4.8 as part of pantsbuild#5922.
@jsirois jsirois mentioned this pull request Oct 11, 2018
Merged
jsirois added a commit to pantsbuild/pants that referenced this pull request Oct 11, 2018
@jsirois
Simplify pants.pex creation, leverage -c. (#6620)
b5cf66b 
This lets the full entry-point live in less places. The `pants` console
script will be much more stable and it's easy to remember / ~obviously
right.

I forgot to leverage the work in
pex-tool/pex#545 when upgrading from
pex 1.4.5 to 1.4.8 as part of #5922.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

@kwlzn kwlzn Awaiting requested review from kwlzn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsirois @illicitonion