Grab latest version from GitHub Release tag #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejcannon
commented
Jul 12, 2023
| "version" | ||
| ] | ||
|
|
||
| latest_tag = ptex.fetch_json("https://github.com/pantsbuild/pants/releases/latest", Accept="application/json")["tag_name"] |
There was a problem hiding this comment.
The good news is this is a normal public URL, and therefore (I assume) doesn't participate in the anonymous API rate limiting 🎉
|
I'll bow out. @kaos is a good reviewer for this I think. |
kaos
approved these changes
Jul 12, 2023
kaos
reviewed
Jul 12, 2023
thejcannon
commented
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the latest Pants meetup and this proposal, we're going to move off of PyPI for distribution, and instead leverage GitHub Releases.
Some reasons given for this pivot:
pip install pantsbuild.pantsscie-pantsuse a PEX in the future, and PyPI wouldn't support that workflowCurrently the latest version is expected to be set by hand. Although that's unlikely to be wrong, we're also changing to have the "latest" marker be automated. Therefore we should be able to rely on it with confidence.
Tested and both before/after yielded the same string (with the GitHub URL performing slightly faster)