Upgrade pants, adjust dev docs, adjust tests for get-pants.sh scrip…

…t name (#145)

This does a bunch of "modernisation" fixes:

- upgrades this repo to use Pants 2.18.1 (which upgrades black and thus requires reformatting some code)
- adjusts the developer docs in the Readme to reference pants, instead of tox (maybe the `tox.ini` could be entirely removed?)
- fixes what was previously `test_pantsup.py` to refer to the new/main `get-pants.sh` name

BUILD

@@ -1,3 +1,3 @@
 shell_sources(name="scripts")
 
-resources(name="scripts_as_resources", sources=["one_step_setup.sh", "pants", "pantsup.sh"])
+resources(name="scripts_as_resources", sources=["one_step_setup.sh", "pants", "get-pants.sh"])

README.md

@@ -6,22 +6,8 @@ Follow the instructions at https://www.pantsbuild.org/docs/installation.
 
 ### Development
 
-We use [tox](https://testrun.org/tox/en/latest/) for test automation. To run the test suite and linters, invoke tox:
+We use Pants for test automation (so recursive!). To run the test suite, linters and formatters:
 
 ```bash
-$ tox
-```
-
-You may run certain checks (`environments` in tox) with `tox -e` (run `tox -a` to see all options):
-
-```bash
-$ tox -e format-run
-$ tox -e lint
-$ tox -e test
-```
-
-You may pass arguments to Pytest like this:
-
-```bash
-$ tox -e test -- -vv -k test_only_bootstraps_the_first_time
+$ pants fmt lint check test ::
 ```

pants.toml

@@ -1,5 +1,5 @@
 [GLOBAL]
-pants_version = "2.15.0rc5"
+pants_version = "2.18.1"
 
 backend_packages.add = [
     "pants.backend.python",

tests/test_pantsup.py → tests/test_get_pants.py

@@ -11,7 +11,7 @@
 def test_installs_pants(tmp_path: Path) -> None:
     cwd = os.getcwd()
     proc = subprocess.run(
-        ["/bin/bash", os.path.join(cwd, "pantsup.sh")],
+        ["/bin/bash", os.path.join(cwd, "get-pants.sh")],
         env={"HOME": str(tmp_path)},
         capture_output=True,
     )

tests/test_one_step_setup.py

@@ -9,7 +9,6 @@
 
 
 def test_runs_on_clean_directory(tmp_path: Path) -> None:
-
     cwd = os.getcwd()
 
     proc = subprocess.run(
@@ -23,7 +22,6 @@ def test_runs_on_clean_directory(tmp_path: Path) -> None:
 
 
 def test_pin_version(tmp_path: Path) -> None:
-
     cwd = os.getcwd()
     env = os.environ.copy()
     env["PANTS_VERSION"] = "2.11.0rc6"
@@ -46,7 +44,6 @@ def test_pin_version(tmp_path: Path) -> None:
 
 
 def test_fails_if_pants_script_present(tmp_path: Path) -> None:
-
     cwd = os.getcwd()
     pants_script = tmp_path / "pants"
     pants_script.touch()
@@ -60,7 +57,6 @@ def test_fails_if_pants_script_present(tmp_path: Path) -> None:
 
 
 def test_fails_if_pants_toml_present(tmp_path: Path) -> None:
-
     cwd = os.getcwd()
     pants_toml = tmp_path / "pants.toml"
     pants_toml.touch()