Null safety #23
Merged
Null safety #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@panuavakul I'm working through updating one of my apps to null safety and using your great tag editor in that project. Thought I would help upgrade to null safety if you're open to the PR :) With Flutter 2.0 just released null safety is now a requirement. |
panuavakul
reviewed
Mar 5, 2021
There was a problem hiding this comment.
Hi @drcdev , thanks for the PR.
Looks great, just a few suggestions below. If you don't have time to deal with the suggestions, please let me know and I can just merge this PR and fix them myself later.
I will probably also make some other improvements, deal with some issues and release 0.1.0 this weekend.
Thanks again.
|
Had a quick look at your review comments and look good. I will test them out in a bit and commit them. Thanks! |
Co-authored-by: Panu Avakul <clay864649@gmail.com>
Co-authored-by: Panu Avakul <clay864649@gmail.com>
|
Hey, LGTM. Thanks again. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update package and example for sound null safety. Incremented version to 0.1.0 per recommendations.