Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to support a Kubernetes nginx deployment and run as non-root #3

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

trnubo
Copy link
Member

@trnubo trnubo commented Feb 1, 2024

Includes

  • Container runs as nginx user
  • Nginx logs to stdout/stderr
  • Nginx port defaults to 8080 and is configurable with PORT env
  • Add README notes about changes
  • Update examples
  • Add k8s-init and k8s-nginx entrypoints, some entry.sh rework
  • Add k8s-init.sh script to perform templating and copy to a volume
  • Add support to templater.sh to update path when given path is not relative to the nginx root
  • Add k8s tests
  • Add test to check env-config.js templating
  • Switch test to use bats-asset help functions

Includes
* Container runs as `nginx` user
* Nginx logs to stdout/stderr
* Nginx port defaults to 8080 and is configurable with PORT env
* Add README notes about changes
* Update examples
* Add k8s-init and k8s-nginx entrypoints, some entry.sh rework
* Add k8s-init.sh script to perform templating and copy to a volume
* Add support to templater.sh to update path when given path is not relative to the nginx root
* Add k8s tests
* Add test to check env-config.js templating
* Switch test to use bats-asset help functions
docs/README.md Outdated Show resolved Hide resolved
docs/example/Dockerfile Outdated Show resolved Hide resolved
k8s-init.sh Show resolved Hide resolved
Copy link
Member

@macropin macropin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trnubo trnubo merged commit e9eb10f into main Feb 1, 2024
1 check passed
@trnubo trnubo deleted the k8s_nonroot_upgrade branch February 1, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants