fix: respect JWK ext for symmetric keys

panva · Nov 7, 2022 · 20557fc · 20557fc
1 parent 84b56ee
commit 20557fc
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/src/key/import.ts b/src/key/import.ts
@@ -261,7 +261,7 @@ export async function importJWK(
       octAsKeyObject ??= jwk.ext !== true
 
       if (octAsKeyObject) {
-        return asKeyObject({ ...jwk, alg, ext: false })
+        return asKeyObject({ ...jwk, alg, ext: jwk.ext ?? false })
       }
 
       return decodeBase64URL(jwk.k)

diff --git a/test/jwk/jwk2key.test.mjs b/test/jwk/jwk2key.test.mjs
@@ -80,6 +80,13 @@ test('oct JWK (ext: true)', async (t) => {
       196, 31, 242, 115, 77, 179, 107, 193, 17, 146, 114,
     ],
   )
+
+  const k = await importJWK(oct, 'HS256', true)
+  t.true('type' in k)
+  t.is(k.type, 'secret')
+  if ('extractable' in k) {
+    t.is(k.extractable, true)
+  }
 })
 
 test('oct JWK (ext: false)', async (t) => {
@@ -89,10 +96,13 @@ test('oct JWK (ext: false)', async (t) => {
     ext: false,
   }
 
-  const k = await importJWK(oct, 'HS256')
+  const k = await importJWK(oct, 'HS256', true)
 
   t.true('type' in k)
   t.is(k.type, 'secret')
+  if ('extractable' in k) {
+    t.is(k.extractable, false)
+  }
 })
 
 test('oct JWK (ext missing)', async (t) => {
@@ -101,10 +111,13 @@ test('oct JWK (ext missing)', async (t) => {
     kty: 'oct',
   }
 
-  const k = await importJWK(oct, 'HS256')
+  const k = await importJWK(oct, 'HS256', true)
 
   t.true('type' in k)
   t.is(k.type, 'secret')
+  if ('extractable' in k) {
+    t.is(k.extractable, false)
+  }
 })
 
 async function testKeyImportExport(t, jwk) {
@@ -221,7 +234,7 @@ test('Uin8tArray can be transformed to a JWK', async (t) => {
   )
 })
 
-conditional({ webcrypto: 0 })('secret key object can be transformed to a JWK', async (t) => {
+test('secret KeyLike can be transformed to a JWK', async (t) => {
   const keylike = await importJWK(
     {
       ext: true,