Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venue #13

Closed
rationalpastime opened this issue Jul 7, 2016 · 6 comments
Closed

Venue #13

rationalpastime opened this issue Jul 7, 2016 · 6 comments

Comments

@rationalpastime
Copy link

Any chance that future updates will parse the venue value from linescore.xml?

Of course, 99% of the time, the venue is just the home team's park, but having venue data would help sort out games like last Sunday's Marlins-Braves contest at Fort Bragg, and the occasional overseas/Puerto Rico contests.

In my case, I use (your excellent) mlbgame in a workflow that includes park adjustments for player stats and home field adjustments for win expectancies. Being able to capture the venue would help ensure that I'm not correcting for park or home field factors that don't apply.

@panzarino
Copy link
Owner

panzarino commented Jul 7, 2016

First, that's awesome that you are using this API in a workflow! I will work on parsing the linescore.xml (which has venue) and will send out a release sometime within a week or two.

@panzarino
Copy link
Owner

Just checked out www.rationalpastime.com, it looks really awesome! I will be consistently checking it throughout the season. Great use of the API!

@rationalpastime
Copy link
Author

Much appreciated. I was planning on using the package for some time, but
when my kid was born and I no longer had time to manually input the data
into excel every morning, I decided I had to buckle down and go all Python
on that bad boy.

On Thursday, July 7, 2016, Zach Panzarino notifications@github.com wrote:

Just checked out www.rationalpastime.com, it looks really awesome! I will
be consistently checking it throughout the season. Great use of the API!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#13 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ASZyT7ufgKGXNGniBnvJLIhQFzKpK0Dfks5qTbP5gaJpZM4JHaiS
.

@panzarino
Copy link
Owner

panzarino commented Jul 19, 2016

I have finished implementing this feature in e863b95. I will release a new version later today/tonight (2.2) (I have to do some doc updates).

@panzarino
Copy link
Owner

Just released the new version, feel free to update. The new overview function is what you will be looking for. Hopefully it works for what you need.

@rationalpastime
Copy link
Author

Awesome. Thank you for this.

On Tue, Jul 19, 2016 at 2:07 PM, Zach Panzarino notifications@github.com
wrote:

Just released the new version, feel free to update. The new overview
function is what you will be looking for. Hopefully it works for what you
need.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#13 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASZyTyGJvmb5Npu4fBuZ_S7TderY8Wm2ks5qXRJigaJpZM4JHaiS
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants