New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actions: add ListParts action #26
Conversation
Codecov Report
@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 91.28% 91.60% +0.31%
==========================================
Files 24 25 +1
Lines 1193 1286 +93
==========================================
+ Hits 1089 1178 +89
- Misses 104 108 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good!! Can you cover set_part_number_marker
and the missing part of sign_with_time
? In order to keep the coverage high :)
This code covered by test in file tests/list_parts.rs. Why check of code coverage don't use this tests? |
- Some code refactoring of delete_objects.rs and list_parts.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now :D thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
No description provided.