Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: add ListParts action #26

Merged
merged 10 commits into from Oct 1, 2021
Merged

Conversation

Cykooz
Copy link
Contributor

@Cykooz Cykooz commented Sep 29, 2021

No description provided.

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #26 (f3a38f4) into main (d2dc709) will increase coverage by 0.31%.
The diff coverage is 93.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   91.28%   91.60%   +0.31%     
==========================================
  Files          24       25       +1     
  Lines        1193     1286      +93     
==========================================
+ Hits         1089     1178      +89     
- Misses        104      108       +4     
Impacted Files Coverage Δ
src/actions/multipart_upload/list_parts.rs 93.25% <93.25%> (ø)
src/actions/delete_objects.rs 69.86% <100.00%> (ø)
src/bucket.rs 98.21% <100.00%> (+1.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2dc709...f3a38f4. Read the comment docs.

Copy link
Collaborator

@guerinoni guerinoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!! Can you cover set_part_number_marker and the missing part of sign_with_time? In order to keep the coverage high :)

@Cykooz
Copy link
Contributor Author

Cykooz commented Oct 1, 2021

This code covered by test in file tests/list_parts.rs. Why check of code coverage don't use this tests?

Copy link
Collaborator

@guerinoni guerinoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now :D thank you

Copy link
Owner

@paolobarbolini paolobarbolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@paolobarbolini paolobarbolini merged commit 85b30e6 into paolobarbolini:main Oct 1, 2021
@Cykooz Cykooz deleted the main branch October 4, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants