Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket::new() returns now a Result instead of Option #34

Merged
merged 4 commits into from Oct 31, 2021

Conversation

manuelpelloni
Copy link
Contributor

Closes #29

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #34 (113cf30) into main (adaf065) will decrease coverage by 0.16%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   91.84%   91.67%   -0.17%     
==========================================
  Files          26       26              
  Lines        1250     1261      +11     
==========================================
+ Hits         1148     1156       +8     
- Misses        102      105       +3     
Impacted Files Coverage Δ
src/bucket.rs 95.93% <76.47%> (-2.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adaf065...113cf30. Read the comment docs.

Copy link
Collaborator

@guerinoni guerinoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/bucket.rs Outdated Show resolved Hide resolved
@paolobarbolini paolobarbolini merged commit a5294a8 into paolobarbolini:main Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bucket::new should return a Result
3 participants