Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the 'full' feature #39

Merged
merged 3 commits into from Nov 6, 2021
Merged

Introduce the 'full' feature #39

merged 3 commits into from Nov 6, 2021

Conversation

paolobarbolini
Copy link
Owner

@paolobarbolini paolobarbolini commented Nov 5, 2021

Part of the reason why rusty-s3 was created is to have a faster to compile alternative to other s3 clients. Unfortunately adding more actions also meant having to add more dependencies.

This adds the enabled by default full feature, which can in the future be split into smaller features without making breaking changes, which makes it possible to disable the more complicated methods and only have to compile the simpler ones. This in turn reduces the number of dependencies

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #39 (d29bde7) into main (cec8e04) will increase coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   91.77%   92.12%   +0.35%     
==========================================
  Files          26       26              
  Lines        1288     1371      +83     
==========================================
+ Hits         1182     1263      +81     
- Misses        106      108       +2     
Impacted Files Coverage Δ
src/actions/mod.rs 100.00% <ø> (ø)
src/credentials/mod.rs 97.72% <ø> (ø)
src/bucket.rs 95.65% <100.00%> (+0.49%) ⬆️
src/signing/mod.rs 96.90% <0.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cec8e04...d29bde7. Read the comment docs.

paolobarbolini and others added 2 commits November 5, 2021 20:25
Signed-off-by: Federico Guerinoni <guerinoni.federico@gmail.com>
@paolobarbolini paolobarbolini marked this pull request as ready for review November 6, 2021 09:03
@paolobarbolini paolobarbolini merged commit 036840b into main Nov 6, 2021
@paolobarbolini paolobarbolini deleted the full-feature branch November 6, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants