Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

credentials: use impl Into<String> #41

Merged
merged 1 commit into from Nov 10, 2021
Merged

Conversation

paolobarbolini
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #41 (f851adc) into main (bb4ff05) will not change coverage.
The diff coverage is 91.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files          26       26           
  Lines        1300     1300           
=======================================
  Hits         1190     1190           
  Misses        110      110           
Impacted Files Coverage Δ
src/credentials/serde.rs 71.05% <0.00%> (ø)
src/credentials/mod.rs 97.72% <100.00%> (ø)
src/credentials/rotating.rs 95.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb4ff05...f851adc. Read the comment docs.

Copy link
Collaborator

@guerinoni guerinoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paolobarbolini paolobarbolini merged commit 5bf39db into main Nov 10, 2021
@paolobarbolini paolobarbolini deleted the credentials-impl-into branch November 10, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants