Ormar p2

[collerek]

• Cleaned ormar db adapter with all up to date ormar features
• Finished ormar db with OrmarBaseOAuthAccountModel
• Added test for ormar db and ensure all pass
• Bumped dependency to ormar >=0.9.0,<0.10.0

So I guess now what is left:

• More tests including some sample fastapi aplications
• Add sections regarding ormar to documentation in all relevant parts (like models, oauth etc.)

Let me know what you think about the changes.
Also included some columns in the code.

[paolodina]

Thank you very much for your revision! You did the most of the work (btw, I was stuck on tests)

I will:

• write some docs along the lines of FastAPI Users SQLAlchemy/MongoDB/Tortoise ORM docs, they share a pretty similar structure
• tests: for that I'd probably ask to FastAPI Users maintainer when I'll do the PR, but looking at their existing test suite I think the tests you wrote could/should be ok (you also add the add/remove oauth2 account tests)
• black + flake8 + mypy

Sorry for bothering with some off-topic, but what should I do now? Is it ok to commit the missing parts (basically the docs), squash the commits into one and then submit the PR?

[collerek]

No need to be sorry! :)

You should merge this one (can be into master since it's your fork anyway).
Pull the changes from master of this fork to your local repo (after merge ofc).
Checkout new branch with descriptive name and add missing docs etc (that way it will be easier for maintainer to see what you want to merge and you can always push to this new branch to update if owner request changes.)
Optionally squash the commits. (Before the push, never squash already pushed commits, you can mess other people git history)
Open pull request from your fork to original repo.

Saw that someone opened an issue for gino, you didn't open one for ormar but since the owner said all backends are welcomed it's should be fine🙂

[collerek]

Btw i forgot to change version of ormar in tool.flit.metadata.requires-extra in toml file to use version >=0.9.0,<0.10.0 so that should also be updated