Asynchronous delete of queues and topics #149
Conversation
|
Thank you for your contribution @danielmarbach! LGTM, but I'll leave it up to @paolosalvatori & @SeanFeldman to review. @SeanFeldman Do you use the naming convention to suffix async methods with |
|
I work with sean, if he would he would be in serious trouble ;)
… Am 26.09.2017 um 14:29 schrieb Tom Kerkhove ***@***.***>:
Thank you for your contribution @danielmarbach!
LGTM, but I'll leave it up to @SeanFeldman to review.
@SeanFeldman Do you use the naming convention to suffix async methods with Async?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
I do think there is probably more cleanup and adjustment necessary but this is a first step in the right direction and if I find some spare time I might be able to send in a few more PRs (nothing promised though) |
| { | ||
| DeleteRelay(relayService); | ||
| } | ||
| await Task.WhenAll(relayServices.Select(DeleteRelay).ToArray()); |
There was a problem hiding this comment.
nit: .ToArray() is not needed.
|
Removed .ToArray() here. |
I've contemplated to piss off @danielmarbach and ask to suffix methods in a code base that is not entirely async... But then he'd not leave me alone 😛 To be fair, the whole async suffix discussion is a mood point. At some point Clemens joked about suffixing the non-async code with a snail emoji (can't find the tweet). I wouldn't mind that 😄 |
|
Thanks @danielmarbach for the improvement :) Keep sending :) Indeed the tool still contains non-async method calls, as it was written before the await/async mechanism was added. Some parts were converted to await/async, but not all of them. |
Before
https://youtu.be/Nl82ePL8nLE
After
https://youtu.be/qSw5AHzIUyw
The video is still processing. But the TLDR version is that deleting is with my example here is almost one minute faster.