Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more IANA json codes #48

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Support more IANA json codes #48

merged 1 commit into from
Nov 19, 2023

Conversation

paolosimone
Copy link
Owner

@paolosimone paolosimone commented Nov 19, 2023

@RVFET review

[...] For example: rdap.nominet.uk/uk/domain/domain.uk will not be formatted even though the response is json

In fact document.contentType: 'application/rdap+json' was not supported. Now the extension should be enabled for all json media types.

Will be available with version 1.1.2

@paolosimone paolosimone merged commit 74847e2 into main Nov 19, 2023
@paolosimone paolosimone deleted the more-iana-json-codes branch November 19, 2023 09:42
@RVFET
Copy link

RVFET commented Nov 19, 2023

8Thank you so much for taking my request into account. Would be great if the extension could fallback to trying to parse the response into json even when content type does not match any json format, just as a last chance, it'd be a great addition.

Edit: I'm aware that it'd create some performance bottlenecks since it'd need to check every page you visit but it could be an option that we can toggle, or perhaps manual wildcard/regex based custom websige matching could help a ton, too.

@paolosimone
Copy link
Owner Author

moved the discussion here #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants