Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update period and digits range #22

Merged
merged 1 commit into from
Aug 18, 2018
Merged

Update period and digits range #22

merged 1 commit into from
Aug 18, 2018

Conversation

paolostivanin
Copy link
Owner

@paolostivanin paolostivanin commented Aug 18, 2018

@paolostivanin paolostivanin changed the title Fix #20 Update period and digits restriction Aug 18, 2018
@paolostivanin paolostivanin changed the title Update period and digits restriction Update period and digits range Aug 18, 2018
@paolostivanin paolostivanin merged commit 1211249 into master Aug 18, 2018
@paolostivanin paolostivanin deleted the rel-1.2.0 branch August 18, 2018 09:51
@magiruuvelvet
Copy link
Contributor

magiruuvelvet commented Aug 18, 2018

i noticed a segfault after playing around with the new changes.

i needed to change this, otherwise it segfaults

static int64_t DIGITS_POWER[] = {1, 10, 100, 1000, 10000, 100000, 1000000, 10000000, 100000000, 1000000000,
                                 10000000000, 100000000000, 1000000000000, 10000000000000, 100000000000000};

the digit count is still limited to 8 because of this

@paolostivanin
Copy link
Owner Author

I'll have a look at it next week! Thanks for the heads-up

@paolostivanin
Copy link
Owner Author

@magiruuvelvet how did you manage to get the segfault? I couldn't reproduce the issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for custom digits
2 participants