Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to hijackresponse 5 #40

Merged
merged 4 commits into from Sep 28, 2020
Merged

Upgrade to hijackresponse 5 #40

merged 4 commits into from Sep 28, 2020

Conversation

gustavnikolaj
Copy link
Collaborator

Using the proposed api from: gustavnikolaj/hijackresponse#24

@coveralls
Copy link

coveralls commented Sep 18, 2020

Coverage Status

Coverage increased (+1.6%) to 100.0% when pulling d03665d on feature/split-hijack into 8cc0182 on master.

Repository owner deleted a comment from coveralls Sep 18, 2020
@gustavnikolaj
Copy link
Collaborator Author

The latest commit updates to the first pre-release of v5. It also removes the err argument to the callback.

@gustavnikolaj gustavnikolaj changed the title Use proposed hijackresponse api Upgrade to hijackresponse 5 Sep 22, 2020
@papandreou
Copy link
Owner

This is nice -- happy to merge it once the api is finalized and 5.0.0 is released!

@gustavnikolaj
Copy link
Collaborator Author

This PR is ready for merge and release :-)

@papandreou papandreou merged commit 9b898b9 into master Sep 28, 2020
@papandreou papandreou deleted the feature/split-hijack branch September 28, 2020 20:24
@papandreou
Copy link
Owner

Released in 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants