Remove lodash #93
Merged
Remove lodash #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papandreou
approved these changes
Jul 15, 2019
| @@ -1,3 +1,4 @@ | |||
| /node_modules/ | |||
| /coverage/ | |||
| /.nyc_output/ | |||
| package-lock.json | |||
There was a problem hiding this comment.
nbd, but we have an .npmrc with package-lock = false, so you shouldn't see package locks appear?
There was a problem hiding this comment.
Oh, something weird going on with my system them, I guess...
There was a problem hiding this comment.
Since some npm commands will behave differently when there’s a lock file, I prefer the strategy of preventing it from being generated in the first place (in libs).
Maybe you have a ~/.npmrc that somehow overrides it? 🤨
But either way it’s ok to also have it in .gitignore, so don’t worry about it.
| function CldrRbnfRuleSet(config) { | ||
| _.extend(this, config); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize this is neither a priority, nor does it have any practical consequences, but I felt tempted to remove lodash as a dependence because it was only used to merge simple objects...