Include error.stack if the callback was called again with an Error.

papandreou · Oct 2, 2014 · 0f165bf · 0f165bf
1 parent a4af0cc
commit 0f165bf
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/lib/passError.js b/lib/passError.js
@@ -14,7 +14,7 @@
         var called = false;
         return function (err) { // ...
             if (called) {
-                throw new Error('passError: The callback was called more than once');
+                throw new Error('passError: The callback was called again with ' + (err ? err.stack : 'no error'));
             }
             called = true;
             if (err) {

diff --git a/test/passError.js b/test/passError.js
@@ -28,11 +28,23 @@ describe('passError', function () {
             expect(successCallback, 'was not called');
         });
 
-        it('should throw an error if called twice', function () {
+        it('should throw an error if called again', function () {
             cb();
             expect(errorCallback, 'was not called');
             expect(successCallback, 'was called once');
-            expect(cb, 'to throw exception', 'passError: The callback was called more than once');
+            expect(cb, 'to throw exception', 'passError: The callback was called again with no error');
+            expect(errorCallback, 'was not called');
+            expect(successCallback, 'was called once');
+        });
+
+        it('should throw an error including the stack if called again with an error', function () {
+            cb();
+            expect(errorCallback, 'was not called');
+            expect(successCallback, 'was called once');
+            var err = new Error('testing testing 123');
+            expect(function () {
+                cb(err);
+            }, 'to throw exception', 'passError: The callback was called again with ' + err.stack);
             expect(errorCallback, 'was not called');
             expect(successCallback, 'was called once');
         });