feat(message-document): Use mask for status indicator #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuraiz
force-pushed
the
mask-document-icon
branch
from
56498dd
to
251fc27
Compare
melix99
force-pushed
the
mask-document-icon
branch
from
251fc27
to
efd2e4d
Compare
marhkb
requested changes
Jun 13, 2023
yuraiz
force-pushed
the
mask-document-icon
branch
from
efd2e4d
to
3c79c94
Compare
yuraiz
force-pushed
the
mask-document-icon
branch
2 times, most recently
from
978c19c
to
786c4fe
Compare
marhkb
requested changes
Jun 15, 2023
yuraiz
force-pushed
the
mask-document-icon
branch
from
786c4fe
to
8d04f95
Compare
marhkb
approved these changes
Jun 17, 2023
|
LGTM. @melix99 do you want to take a look at the css stuff anyway? |
melix99
reviewed
Jun 17, 2023
melix99
reviewed
Jun 17, 2023
melix99
reviewed
Jun 17, 2023
With mask it correctly matches message bubble background
yuraiz
force-pushed
the
mask-document-icon
branch
from
8d04f95
to
199cb75
Compare
melix99
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With mask it correctly matches message background
That PR doesn't include gradient bubbles