Skip to content

Commit

Permalink
rubocop 0.71.0 (was 0.62.0)
Browse files Browse the repository at this point in the history
Updated rubocop to 0.71.0
Updated rubocop-rspec to 1.33.0
Added rubocop-performance 1.3.0

Manually edited .rubocop_todo.yml
  • Loading branch information
aried3r authored and jaredbeck committed Jun 7, 2019
1 parent f4660f9 commit 24ad1f4
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 4 deletions.
1 change: 1 addition & 0 deletions .rubocop.yml
@@ -1,4 +1,5 @@
require:
- rubocop-performance
- rubocop-rspec

inherit_from: .rubocop_todo.yml
Expand Down
19 changes: 17 additions & 2 deletions .rubocop_todo.yml
Expand Up @@ -3,11 +3,14 @@ require: rubocop-rspec
# Remove these configuration records
# one by one as the offenses are removed from the code base.

Layout/AlignArguments:
Enabled: false

Metrics/AbcSize:
Max: 21 # Goal: 15
Max: 20 # Goal: 15

Metrics/CyclomaticComplexity:
Max: 8 # Goal: 6
Max: 7 # Goal: 6

Metrics/PerceivedComplexity:
Max: 9 # Goal: 7
Expand All @@ -18,6 +21,18 @@ Naming/MemoizedInstanceVariableName:
RSpec/ContextWording:
Enabled: false

RSpec/HooksBeforeExamples:
Exclude:
- spec/controllers/articles_controller_spec.rb
- spec/models/version_spec.rb
- spec/paper_trail/config_spec.rb
- spec/paper_trail/request_spec.rb
- spec/paper_trail_spec.rb

RSpec/ImplicitSubject:
Exclude:
- spec/paper_trail/events/base_spec.rb

RSpec/InstanceVariable:
Exclude:
- spec/paper_trail/associations/belongs_to_spec.rb
Expand Down
5 changes: 3 additions & 2 deletions paper_trail.gemspec
Expand Up @@ -41,7 +41,8 @@ has been destroyed.
s.add_development_dependency "pg", "~> 1.0"
s.add_development_dependency "rake", "~> 12.3"
s.add_development_dependency "rspec-rails", "~> 3.8"
s.add_development_dependency "rubocop", "~> 0.62.0"
s.add_development_dependency "rubocop-rspec", "~> 1.28.0"
s.add_development_dependency "rubocop", "~> 0.71.0"
s.add_development_dependency "rubocop-performance", "~> 1.3.0"
s.add_development_dependency "rubocop-rspec", "~> 1.33.0"
s.add_development_dependency "sqlite3", "~> 1.3.13"
end

0 comments on commit 24ad1f4

Please sign in to comment.