Ensure YAML safe loading in Rails 6.1 #1399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlconnor
force-pushed
the
yamlSafeLoadRails6
branch
2 times, most recently
from
51b17d3
to
4a5bd75
Compare
As part of the fix for CVE-2022-32224 Rails intruduced safe YAML loading and the `ActiveRecord.yaml_column_permitted_classes` config. PaperTrail added support for respecting the new configuration here paper-trail-gem#1397 The CVE-2022-32224 fix was also backported to Rails versions 5.2.8.1, 6.0.5.1, and, 6.1.6.1, however the name of the confiuration is slightly different from that in Rails 7.x. 7.0.3.1 ActiveRecord.yaml_column_permitted_classes 6.1.6.1 ActiveRecord::Base.yaml_column_permitted_classes 6.0.5.1 ActiveRecord::Base.yaml_column_permitted_classes 5.2.8.1 ActiveRecord::Base.yaml_column_permitted_classes PaperTrail currently doesn't support this alternative configuration naming, which means it will silent fall back to unsafe YAML loading. This commit updates `PaperTrail::Serializers::YAML` to be compatible with safe YAML loading for the Rails 5.2 / 6.0 / 6.1 branches.
tlconnor
force-pushed
the
yamlSafeLoadRails6
branch
from
4a5bd75
to
520cf4d
Compare
Can you write new tests so that we maintain the same level of coverage? If that is difficult because of the conditionals, then I'm OK with lowering the coverage requirement slightly. (We're talking about fractions of a percentage point, right?) Also, Simplecov is already ignoring |
|
Merged offline. Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the fix for CVE-2022-32224 Rails intruduced safe YAML loading and the
ActiveRecord.yaml_column_permitted_classesconfig.PaperTrail added support for respecting the new configuration here #1397
The CVE-2022-32224 fix was also backported to Rails versions 5.2.8.1, 6.0.5.1, and, 6.1.6.1, however the name of the configuration is slightly different from that in Rails 7.x.
PaperTrail currently doesn't support this alternative configuration naming, which means it will silent fall back to unsafe YAML loading.
This PR updates
PaperTrail::Serializers::YAMLto be compatible with safe YAML loading for the Rails 5.2 / 6.0 / 6.1 branches.master(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.