Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent class attributes name clashes. #157

Merged
merged 3 commits into from Nov 6, 2012
Merged

Conversation

budu
Copy link
Contributor

@budu budu commented May 7, 2012

Here's my fix for #156

budu added 2 commits May 7, 2012 16:13
…_trail_options` attribute which should reduce the risk of name clashes with existing code base or other gems.
@airblade
Copy link
Collaborator

airblade commented May 8, 2012

Thanks for this.

Unless I'm mistaken, the :if and :unless options have got lost in the refactoring. Please could you add them back in?

@budu
Copy link
Contributor Author

budu commented May 8, 2012

I'm not sure if there's something wrong with the :if and :unless options, the test 'A record with defined "if" and "unless" attributes' pass on my machine, do you have an example which doesn't work?

@edtsech
Copy link
Contributor

edtsech commented May 11, 2012

@budu, Do you have this error in test suite test_versions_works_with_custom_timestamp_field?

@budu
Copy link
Contributor Author

budu commented May 11, 2012

Not on my side, all test pass.

@edtsech
Copy link
Contributor

edtsech commented May 11, 2012

My bad, all test pass. Btw good pull request.

@batter batter merged commit 4c44c24 into paper-trail-gem:master Nov 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants