Support conditional paper trail on destroy

[l4rk]

Howdy!

Background: We have a paper-trailed Contact model which has_many :email_addresses. The EmailAddress model also has a paper trail. We have a custom way of undo-ing deletes of parents, and all their children.

Problem: If someone blanks out an email in the web UI, then we destroy that email row. But, we don't want a EmailAddress version to be created in that case.

Other problem: However, we do want to save a version of both the EmailAddress and the Contact, when a contact is deleted.

Solution: Pass along the :if conditional to the destroy code. We have a conditional expression that knows the difference between the parent Contact delete, versus the one-off deletion of an EmailAddress due to blanking it out in the UI.

Thanks!

[travisbot]

This pull request fails (merged a517bc3 into e870e0d).

[l4rk]

BTW, the tests pass for us on an older version of Rails. paper_trail will need to be tweaked to keep up with the latest Rails.

[batter]

Thanks, this does indeed appear to be a bug. If the :if conditional is not met, then a version should not be saved for a destroy action either.