Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Travis against postgres and mysql. #344

Merged
merged 8 commits into from Mar 18, 2014

Conversation

rposborne
Copy link
Contributor

Allow travis to catch issues such as #314

@batter
Copy link
Collaborator

batter commented Mar 14, 2014

I believe we'd need to add the pg and mysql2 gems to the development dependencies. It might also make sense to refactor some of these test gems into the Gemfile in appropriate groupings.

@batter batter added this to the 3.0.1 milestone Mar 14, 2014
@batter batter self-assigned this Mar 14, 2014
@batter
Copy link
Collaborator

batter commented Mar 14, 2014

@rposborne
Copy link
Contributor Author

@batter how do you want me to handle the the rspec test's where you are cloning the sqlite3 db.

I am inclined to just spawn db's and rerun migrations for the foo and bar namespace.

@batter
Copy link
Collaborator

batter commented Mar 14, 2014

I'm not sure what the best way to handle it is, so you can tackle it whatever way works for you. It's probably not even necessary to run those specs with MySQL or Postgres because they are simply there to demonstrate the ability to use the VersionConcern module across multiple DB's with ease.

@batter batter modified the milestones: 3.0.2, 3.0.1 Mar 14, 2014
@rposborne
Copy link
Contributor Author

So PG has two transient failing specs that I haven't been able to nail down just yet. SQLITE is still green.

As for mysql it looks to be failing due to the timestamp bug, most of the reifies are returning the wrong version.

To run tests against a another db

export DB=mysql

or

export DB=postgres

@rposborne
Copy link
Contributor Author

@batter This should be good to merge into mainline, I have compressed all the commits regarding to setting up the environment. Each commit after that is addressing specific issues regarding getting postgres to pass.

This should give us good ground to stand on for getting ready to fix MYSQL support.

@batter
Copy link
Collaborator

batter commented Mar 17, 2014

@rposborne - Fantastic! Thanks so much for all the hard work on this, I really appreciate it. I'm going to take a closer look later today but at a glance everything looks good for the most part. I'll try to get it merged shortly.

@rposborne
Copy link
Contributor Author

@batter My pleasure, it's fun to dig into some non client work sometimes! I think it will be much better for the project in the long run testing against the DB's we all use in production.

@batter
Copy link
Collaborator

batter commented Mar 17, 2014

Wow, outstanding work. Looks like you even caught an unrelated bug in cb46e87. I'll see if I can write a spec / test for that too. I have no doubt that this will be much better for the project in making sure it is compatible with multiple database types. Thanks again!

@rposborne
Copy link
Contributor Author

@batter, Thanks for making my day! Glad I could help.

@batter batter merged commit 4fe79ff into paper-trail-gem:master Mar 18, 2014
@rposborne rposborne deleted the feature/test-pg-mysql branch March 18, 2014 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants