New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move update from before to after_update #375
Conversation
This behavior should probably be added to the create event too. I'll see what I can do with the failed travis build. It's a bit odd, since the values are apparently equal, but are not. |
I've found a problem with protected attributes that doesn't show up in the test suite. |
The problem didn't show up because |
Any thoughts on this one failed test on Travis CI? I installed |
Looks like Travis jruby-d18 with postgres has some transient problem. Last test succeeded. |
Thanks so much for the PR. Sorry it's taken me so long to get to this, looks great! |
@batter No worries! I know the dilemma... :{ |
All tests pass, with one new test. This seemed a little too easy, so perhaps it should be tested by a few people. I will use it and comment back here on any problems.
Line 734 in
tests/unit/model_tests.rb
had to be changed because line 728 now creates a version within the expected range.