Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move update from before to after_update #375

Merged
merged 1 commit into from Jul 30, 2014

Conversation

straydogstudio
Copy link
Contributor

All tests pass, with one new test. This seemed a little too easy, so perhaps it should be tested by a few people. I will use it and comment back here on any problems.

Line 734 in tests/unit/model_tests.rb had to be changed because line 728 now creates a version within the expected range.

@straydogstudio
Copy link
Contributor Author

This behavior should probably be added to the create event too.

I'll see what I can do with the failed travis build. It's a bit odd, since the values are apparently equal, but are not.

@straydogstudio
Copy link
Contributor Author

I've found a problem with protected attributes that doesn't show up in the test suite.

@straydogstudio
Copy link
Contributor Author

The problem didn't show up because :created_at was made accessible in the dummy app initializer, so the test suite passed while my code didn't. I moved that to VersionConcern.

@straydogstudio
Copy link
Contributor Author

Any thoughts on this one failed test on Travis CI? I installed jruby-18 and postgresql and all tests pass.

@straydogstudio
Copy link
Contributor Author

Looks like Travis jruby-d18 with postgres has some transient problem. Last test succeeded.

@batter
Copy link
Collaborator

batter commented Jul 29, 2014

Thanks so much for the PR. Sorry it's taken me so long to get to this, looks great!

@straydogstudio
Copy link
Contributor Author

@batter No worries! I know the dilemma... :{

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants