Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Config.enabled backed by a thread variable #539 #541

Merged
merged 1 commit into from Jun 8, 2015

Conversation

stormsilver
Copy link
Contributor

No description provided.

@batter
Copy link
Collaborator

batter commented May 28, 2015

Perhaps it makes more sense to just store it in the PaperTrail#paper_trail_store, which is backed by the thread-safe RequestStore library?

@stormsilver
Copy link
Contributor Author

@batter I looked at that initially. I haven't seen RequestStore before but it looked like it really wanted a request to work properly. I'll take another swing through it and see about using the paper_trail_store.

@stormsilver
Copy link
Contributor Author

@batter Yep, as I looked into RequestStore it's obviously just a wrapper around sticking a hash with a name onto the thread. I replaced Thread with PaperTrail.paper_trail_store and it seemed to work okay - let me know if that's what you were thinking or not.

@batter batter added this to the 4.0.0 milestone Jun 8, 2015
batter added a commit that referenced this pull request Jun 8, 2015
Make Config.enabled backed by a thread variable #539
@batter batter merged commit a158772 into paper-trail-gem:master Jun 8, 2015
batter added a commit that referenced this pull request Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants