Docs: Do not recommend initializer #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredbeck
changed the title
| # app/models/paper_trail/version.rb | ||
| module PaperTrail | ||
| class Version < ActiveRecord::Base | ||
| include VersionConcern |
There was a problem hiding this comment.
I think we want to be explicit here and have this line read include PaperTrail::VersionConcern just to make sure there is no confusion as to where that module comes from.
An alternative to #492 [ci skip]
jaredbeck
force-pushed
the
do_not_recommend_initializer
branch
from
076f981
to
e472b7b
Compare
|
Thanks Ben, I made the changes you recommended. |
jaredbeck
added a commit
that referenced
this pull request
Jun 29, 2015
Docs: Do not recommend initializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #492
@batter @TobiasBales