Destroy callback default changed to :before #683
Conversation
|
There may be a better alternative, see discussion in #682. |
|
Also, if we were to proceed with this PR, it would need a test, please. |
Actually, we don't have tests set up for rails 5 yet, do we? I'll see if I can do that. |
|
I've tried setting up a Rails 5 env but it looks like it might be a bit premature (dependencies force us to also support Sinatra 2.0.0 which is alpha, the |
I'm actually working on this right now :) I'm trying out appraisal. If you want to email me (jared at jaredbeck dot com) we can hop on skype or something. |
jaredbeck
changed the title
|
This is looking good. Can you squash your commits, please? |
|
All done - please re-review. |
| @@ -5,7 +5,9 @@ module VersionConcern | |||
| extend ::ActiveSupport::Concern | |||
|
|
|||
| included do | |||
| belongs_to :item, :polymorphic => true | |||
| opts = {:polymorphic => true} | |||
| opts[:required] = false if ActiveRecord::Base.respond_to? :belongs_to_required_by_default | |||
There was a problem hiding this comment.
Do we need both this change (required: false) and the change to the default recording_order?
There was a problem hiding this comment.
We don't - I was trying to revert that. Let me try again.
Also warn if paper_trail_on_destroy(:after) is combined with ActiveRecord belongs_to_required_by_default
Destroy callback default changed to :before
|
Merged, thanks Owen! |
|
👍 |
To allow after_destroy versioning with Rails 5; fixes #682