Add a way to disable in all threads #717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renames config methods to clarify which are thread-safe and which are not. Deprecates old methods whose names were unclear. - Adds rails config option: config.paper_trail.enabled - See initializer in paper_trail/frameworks/rails/engine.rb - Organizes docs re: the many ways of disabling Originally contributed by Herman verschooten, heavily modified by Jared Beck. Squashed for posterity.
This was referenced Feb 22, 2016
|
#720 is a simpler alternative to this, based on conversation with @seanlinsley in #635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands on @Hermanverschooten's suggestion in #695, adds a way to disable PT in all threads, hopefully fixes #635.
Initially, I was concerned about having both a thread-safe flag and thread-unsafe flag. This PR mitigates that concern by giving these methods very explicit names, like
enabled_in_all_threads=andenabled_in_current_thread=.config.paper_trail.enabled. See initializer inpaper_trail/frameworks/rails/engine.rbBen, I liked your suggestion in #635 that the all-threads flag be immutable, but I didn't see immediately how to implement said immutability given the way we apply the rails config option in
engine.rb.