Fix Style/MultilineTernaryOperator offenses #754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are all fine. I'd prefer to extract private methods, but that can happen later. Please rebase. |
magni-
force-pushed
the
rubocop_multiline_ternary
branch
from
3660aad
to
271ff8b
Compare
magni-
force-pushed
the
rubocop_multiline_ternary
branch
from
271ff8b
to
95b9d53
Compare
| @@ -284,9 +282,8 @@ def reify_has_many_through(transaction_id, associations, model, options = {}) | |||
| # table, this method would return the constant `Fruit`. | |||
| def version_reification_class(version, attrs) | |||
| inheritance_column_name = version.item_type.constantize.inheritance_column | |||
| class_name = attrs[inheritance_column_name].blank? ? | |||
There was a problem hiding this comment.
Do people ever set inheritance_column to "" ? That's the only case in which this would break...
Happy to revert this change if needed. Looking through git, it's been blank? since the code was first written in 2009 (so not in response to a bug report from someone using inheritance_column = "").
There was a problem hiding this comment.
Do people ever set inheritance_column to "" ?
Seems unlikely, but we should not be changing behavior in a linter commit. If we are going to make that change, please make a separate PR. Thanks.
Merged
|
Closed by #768 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another small PR from #752