Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit dependency on activesupport #859

Merged
merged 1 commit into from Sep 4, 2016

Conversation

jaredbeck
Copy link
Member

activerecord depends on activesupport, so there's no need for us
to explicitly depend on it.

activerecord depends on activesupport, so there's no need for us
to explicitly depend on it.
@jaredbeck jaredbeck merged commit fd7756b into master Sep 4, 2016
@jaredbeck jaredbeck deleted the redundant_dependency branch September 4, 2016 03:39
@batter
Copy link
Collaborator

batter commented Sep 6, 2016

True, ActiveRecord does depend on ActiveSupport, so perhaps the explicit dependency is unecessary, however, there are parts of the code where we utilize ActiveSupport directly, and if at some point in the future ActiveSupport was removed as a dependency for ActiveRecord (doubtful this would happen anytime soon if at all), then it would break the code.

I always think it's better to be explicit about these things. Sorry for not chiming in sooner.

@jaredbeck
Copy link
Member Author

.. if at some point in the future ActiveSupport was removed as a dependency for ActiveRecord ..

Seems unlikely, but if you want to revert this it's fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants