Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use send() for #attribute_was (private in Rails 4.0) #929

Closed
wants to merge 1 commit into from

Conversation

jeanmartin
Copy link

private method 'attribute_was' called for ... is what you currently get trying to use paper_trail (6.0.2) with Rails 4.0(.13). See similar problem in lwe/simple_enum#70.

@jaredbeck
Copy link
Member

Hi Jan, This looks good, but please add:

  1. a comment like TODO: after dropping support for rails 4.0, remove send, because attribute_was is no longer private.
  2. a changelog entry under "fixed"

Also, please upgrade your copy of rails as soon as possible. Rails 4.0 has reached EOL. We have already stopped testing against rails < 4.2, and will probably change our gemspec soon to forbid rails < 4.2.

@jaredbeck
Copy link
Member

jaredbeck commented Mar 2, 2017

Jan, Here's a friendly reminder to please make the requested changes. Thanks!

@goodviber
Copy link

Hi, is the change implemented?

@jaredbeck
Copy link
Member

Hi, is the change implemented?

No, this PR requires changes by Jan and will be closed soon if they are not made.

@jaredbeck
Copy link
Member

Closing via #936, which also resumes CI testing against AR 4.0 for now, but please please please upgrade your EOL rails ASAP.

Thanks for bringing this to our attention, Jan.

@jaredbeck jaredbeck closed this Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants