Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyrights to use "Paperclip Contributors" #470

Merged
merged 1 commit into from Oct 10, 2022

Conversation

drueck
Copy link
Contributor

@drueck drueck commented Oct 7, 2022

Addresses issue #390

Updates the name of the copyright holder in each of the licenses to "Paperclip Contributors"

I wasn't sure if we wanted to change the dates to match? Or if there was a reason the dates on the two licenses were different, so I left that the same. Please let me know if there are any other changes that should be made. This is my first time contributing to this project, so please also let me know if there are any conventions I should have followed that I didn't. :)

@tiagolobocastro
Copy link
Collaborator

Thanks @drueck !
If I had to guess when the apache license was copied Ravi forgot to update it.
Let's update the date as well if you don't mind :)

@drueck
Copy link
Contributor Author

drueck commented Oct 7, 2022

Thanks @drueck ! If I had to guess when the apache license was copied Ravi forgot to update it. Let's update the date as well if you don't mind :)

Haha, yeah, that makes sense. Updated so they're both 2019.

@tiagolobocastro
Copy link
Collaborator

Thanks @drueck ! If I had to guess when the apache license was copied Ravi forgot to update it. Let's update the date as well if you don't mind :)

Haha, yeah, that makes sense. Updated so they're both 2019.

Sorry I meant to 2022

@drueck
Copy link
Contributor Author

drueck commented Oct 8, 2022

Sorry I meant to 2022

My bad. I wasn't sure what date was supposed to be used, so I googled it, and I misinterpreted what I read. It said something like that it should be the year the copyright was applied, which I took to mean the first year that the copyright was applied, but after further reading, I discovered that it means the year that it is currently applied, which I guess is the most recent year of changes/releases. 😅 So yeah, 2022 makes sense, and also you asked me to do that, so either way, updated. Sorry for so much back and forth on a tiny change. But thanks for the opportunity to contribute. I'll be taking a look at other code issues hopefully this weekend to see if there's something more useful I can contribute as well.

@tiagolobocastro
Copy link
Collaborator

Sorry I meant to 2022

My bad. I wasn't sure what date was supposed to be used, so I googled it, and I misinterpreted what I read. It said something like that it should be the year the copyright was applied, which I took to mean the first year that the copyright was applied, but after further reading, I discovered that it means the year that it is currently applied, which I guess is the most recent year of changes/releases. sweat_smile So yeah, 2022 makes sense, and also you asked me to do that, so either way, updated. Sorry for so much back and forth on a tiny change. But thanks for the opportunity to contribute. I'll be taking a look at other code issues hopefully this weekend to see if there's something more useful I can contribute as well.

No worries at all, I also wasn't entirely sure what the correct behaviour should be, though other projects seem to have also understood it like this.

Thank you!

@tiagolobocastro tiagolobocastro merged commit 4627be0 into paperclip-rs:master Oct 10, 2022
@shymega shymega mentioned this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants