Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need favicon! #2

Closed
rhyneav opened this issue Oct 28, 2017 · 18 comments
Closed

Need favicon! #2

rhyneav opened this issue Oct 28, 2017 · 18 comments

Comments

@rhyneav
Copy link
Member

rhyneav commented Oct 28, 2017

Oops, don't have a favicon yet.

image

@TotomInc
Copy link
Contributor

Do you have an idea for an "official" logo?

@rhyneav
Copy link
Member Author

rhyneav commented Nov 14, 2017

What's ironic, is that the Chrome default favicon of a blank page is pretty fitting for PaperCSS. So maybe a more cartooned version of that? I'm open for any ideas you (or anyone else!) may have.

@afzalsayed96
Copy link
Contributor

afzalsayed96 commented Nov 19, 2017

I suggest this should be the favicon

favicon

@TotomInc
Copy link
Contributor

@afzalsayed96 thanks for your submission, but I feel you should also sharp the inside-borders of the icon, it looks a bit too rough. What are your thoughts @rhyneav ?

@afzalsayed96
Copy link
Contributor

@TotomInc I didn't quite get you.
Built this favicon using papercss itself.

HTML

<div class="row flex-center">
      <div class="row flex-center child-borders">
          <h1>P</h1>
       </div>
</div>

CSS

.child-borders > * {
    border: 4px solid #41403e;
}
h1 {
    font-size: 4rem;
    padding: 0% 15%;
}

@rhyneav
Copy link
Member Author

rhyneav commented Nov 20, 2017

I dig it! Favicon made by the framework, nice!

@TotomInc I see your point, but I think the favicon will be too small to really see that it's not perfectly imperfect on the inside. To that point, what browser did you use to display the icon for the screenshot @afzalsayed96?

@nfuad
Copy link

nfuad commented Nov 20, 2017

@rhyneav, You are right, Chrome's default favicon is a great fit for your framework. I wondered about it too. and maybe we could replicate this same icon to display on other browsers too... What do you say?

And I have found a solution for you. And here's a preview:
ms-icon-150x150

And I would say, imperfectness won't be necessary ( just for favicon ). If you like my idea, I can complete the process for you.

BTW, loved PaperCSS. Keep up the great work. we're happy to contribute.

Nafis Fuad
@Nafis-Fuad

@afzalsayed96
Copy link
Contributor

afzalsayed96 commented Nov 20, 2017

@rhyneav the previous preview was using Firefox. Here's a preview in Chrome

favicon chrome

For Edge, favicon cannot be viewed in localhost but it will work perfectly on deployed webpage
If you cannot view the favicon on your local machine then try clearing cache

@TotomInc
Copy link
Contributor

@afzalsayed96 favicon looks a bit too light IMO, and the borders are not enough visible.

@Nafis-Fuad is it possible to add something like the P with the PaperCSS font use? It will customize it a bit more, otherwise it's a nice favicon!

@nfuad
Copy link

nfuad commented Nov 20, 2017

@TotomInc, Thank you for giving my favicon a thought. And yeah, I like your idea. Definitely worth a try.

@Nafis-Fuad

@nfuad
Copy link

nfuad commented Nov 20, 2017

Maybe this one helps.

favicon-real2

Had to try a lot of combinations. But this one worked for me. Hope you'll find it interesting.

I've generated all the files required.
@Nafis-Fuad

@rhyneav
Copy link
Member Author

rhyneav commented Nov 20, 2017

@Nafis-Fuad could you please link a screenshot of what it would look like in a browser? Similar to what @afzalsayed96 has done.

@TotomInc
Copy link
Contributor

What's the state of the favicon? Have you done a choice?

@rhyneav
Copy link
Member Author

rhyneav commented Nov 20, 2017

No decision yet @TotomInc. Wanted to see what @Nafis-Fuad's looked like in a browser first.

I personally like @afzalsayed96's a lot. I think it's neat that it was made by the framework. Plus, he already has #38 open with it.

@nfuad
Copy link

nfuad commented Nov 21, 2017

Here you go, @rhyneav.

favicon-test

@Nafis-Fuad

@TotomInc
Copy link
Contributor

I personally prefer @afzalsayed96's favicon, your favicon @Nafis-Fuad is a bit messy, maybe because of the top right folding border.

@rhyneav
Copy link
Member Author

rhyneav commented Nov 21, 2017

Totally agree. The fold looks great in a bigger image, but gets a little distorted when in a small icon. Thank you for putting that together though, @Nafis-Fuad!

I'm going to go ahead and merge in #38 with @afzalsayed96's favicon.

@rhyneav rhyneav closed this as completed Nov 21, 2017
@nfuad
Copy link

nfuad commented Nov 21, 2017

It's Ok.

@Nafis-Fuad

rhyneav pushed a commit that referenced this issue Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants